Skip to content

Fixes for XM 4.5 and netstandard13 and updated comments (#1758) - #1777

Merged
rolfbjarne merged 1 commit into
cycle9from
cycle9-net13-fix
Mar 9, 2017
Merged

Fixes for XM 4.5 and netstandard13 and updated comments (#1758)#1777
rolfbjarne merged 1 commit into
cycle9from
cycle9-net13-fix

Conversation

@chamons

@chamons chamons commented Feb 27, 2017

Copy link
Copy Markdown
Contributor
  • Update comments on XM45.targets file
  • Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades
  • Note: MSBuild with XM 4.5 is still broken for now

- Update comments on XM45.targets file
- Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades
- Note: MSBuild with XM 4.5 is still broken for now
@chamons chamons added the do-not-merge Do not merge this pull request label Feb 27, 2017
@chamons

chamons commented Feb 27, 2017

Copy link
Copy Markdown
Contributor Author

Don't merge until card approved from C9.

@spouliot spouliot added the requires-qa-before-merge The pull request requires QA to approve it before it can be merged label Feb 27, 2017
@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@spouliot spouliot added requires-approval-before-merge The pull request requires special approval before it can be merged and removed do-not-merge Do not merge this pull request labels Feb 28, 2017
@spouliot spouliot added this to the cycle9 milestone Feb 28, 2017
@rolfbjarne

Copy link
Copy Markdown
Member

@rolfbjarne
rolfbjarne merged commit 5cd8e93 into cycle9 Mar 9, 2017
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Mar 27, 2017
…dotnet#1777)

- Update comments on XM45.targets file
- Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades
- Note: MSBuild with XM 4.5 is still broken for now
@dalexsoto
dalexsoto deleted the cycle9-net13-fix branch January 19, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-approval-before-merge The pull request requires special approval before it can be merged requires-qa-before-merge The pull request requires QA to approve it before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants