Skip to content

[intents] Updated to Xcode8.3 Beta 5 - #1853

Merged
dalexsoto merged 1 commit into
dotnet:xcode8.3from
dalexsoto:intents
Mar 9, 2017
Merged

[intents] Updated to Xcode8.3 Beta 5#1853
dalexsoto merged 1 commit into
dotnet:xcode8.3from
dalexsoto:intents

Conversation

@dalexsoto

Copy link
Copy Markdown
Member

Apple added API_UNAVAILABLE(watchos) to

  • (INSiriAuthorizationStatus)siriAuthorizationStatus
  • (void)requestSiriAuthorization:(void (^)(INSiriAuthorizationStatus status))handler

So we got the availability right :D

Apple added API_UNAVAILABLE(watchos) to

+ (INSiriAuthorizationStatus)siriAuthorizationStatus
+ (void)requestSiriAuthorization:(void (^)(INSiriAuthorizationStatus status))handler

So we got the availability right :D
Comment thread src/intents.cs
Canceled,
Failed
Failed,
Unpaid

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: you can add a comma after the last element in an enum, that way there will be less noise in the diff when you add more elements (since you don't have to modify the last line to add the comma).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are totally right 👍

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@dalexsoto

Copy link
Copy Markdown
Member Author

Test failure apitest mac -> https://bugzilla.xamarin.com/show_bug.cgi?id=46116

@dalexsoto
dalexsoto merged commit b74cef2 into dotnet:xcode8.3 Mar 9, 2017
@dalexsoto
dalexsoto deleted the intents branch March 9, 2017 20:26
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Mar 28, 2017
Apple added API_UNAVAILABLE(watchos) to

+ (INSiriAuthorizationStatus)siriAuthorizationStatus
+ (void)requestSiriAuthorization:(void (^)(INSiriAuthorizationStatus status))handler

So we got the availability right :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants