Skip to content

[tests][linksdk][watchos] Fix HttpClientHandler tests for CFNetwork/watchOS - #186

Merged
spouliot merged 1 commit into
dotnet:masterfrom
spouliot:watchos-cfnetwork-fix
Jun 14, 2016
Merged

[tests][linksdk][watchos] Fix HttpClientHandler tests for CFNetwork/watchOS#186
spouliot merged 1 commit into
dotnet:masterfrom
spouliot:watchos-cfnetwork-fix

Conversation

@spouliot

Copy link
Copy Markdown
Contributor

As noted in PR 177 [1] this does not build on watchOS since CFNetwork
is not supported on that platform. Uncaught as the PR bots don't build,
nor run, the tests yet.

[1] #177

…atchOS

As noted in PR 177 [1] this does not build on watchOS since CFNetwork
is not supported on that platform. Uncaught as the PR bots don't build,
nor run, the tests yet.

[1] dotnet#177
@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Build success

@spouliot
spouliot merged commit f50b82d into dotnet:master Jun 14, 2016
@spouliot
spouliot deleted the watchos-cfnetwork-fix branch June 17, 2016 05:07
@akoeplinger

Copy link
Copy Markdown
Member

@spouliot this doesn't fix the build error in make -C tests "build-watchos-sim-link sdk" V=1:

Errors:

/Users/alexander/dev/xamarin-macios/xamarin-macios/tests/linker-ios/link sdk/link sdk-watchos.csproj (Build) ->
/Users/alexander/dev/xamarin-macios/xamarin-macios/_ios-build/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets (_ResolveWatchAppReferences target) ->
/Users/alexander/dev/xamarin-macios/xamarin-macios/tests/linker-ios/link sdk/link sdk-watchos-app.csproj (default targets) ->
/Users/alexander/dev/xamarin-macios/xamarin-macios/_ios-build/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets (_ResolveAppExtensionReferences target) ->
/Users/alexander/dev/xamarin-macios/xamarin-macios/tests/linker-ios/link sdk/link sdk-watchos-extension.csproj (default targets) ->
/Library/Frameworks/Mono.framework/Versions/4.4.0/lib/mono/4.5/Microsoft.CSharp.targets (CoreCompile target) ->

    HttpClientHandlerTest.cs(46,29): error CS0246: The type or namespace name `CFNetworkHandler' could not be found. Are you missing an assembly reference?

     3 Warning(s)
     1 Error(s)

Time Elapsed 00:00:01.3508830
make: *** [build-watchos-sim-link sdk] Error 1

@spouliot

Copy link
Copy Markdown
Contributor Author

@akoeplinger added wrong file :( should be fixed now

@akoeplinger

Copy link
Copy Markdown
Member

It is, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants