[CoreText] CTParagraphStyle uses the incorrect float return type. Fixes bug 54148. - #1975
Merged
Conversation
… settings from CTParagraphStyleSettings https://bugzilla.xamarin.com/show_bug.cgi?id=54148 CTParagraphStyle float properties have the incorrect float return type, the headers state this API's returns CGFloats (aka nfloat) instead of floats this used to work ok fetching them due to there is no difference in size for 32 bits devices but once 64 bit devices appeared the API began to fail The actual method that fetches the values `CTParagraphStyleGetValueForSpecifier` asks for the size of the returned data and we used to give the size of a float which is incorrect in 64 bits devices and the API call just correctly returned false because it could not write back the value to us. Added tests for the full properties available on CTParagraphStyle
Contributor
|
Build success |
spouliot
suggested changes
Apr 9, 2017
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
Looks good but please add a comment to the weird Dispose call that points back to the PR (since it's the only place where it's explained). That will help git blame future questions. Thanks!
Member
Author
|
@spouliot added |
spouliot
approved these changes
Apr 9, 2017
Contributor
|
Build success |
rolfbjarne
approved these changes
Apr 10, 2017
Contributor
|
@dalexsoto Looks safe to backport to |
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Apr 10, 2017
…es bug 54148. (dotnet#1975) * [CoreText] Fix bug 54148 - CoreText.CTParagraphStyle does not pick up settings from CTParagraphStyleSettings https://bugzilla.xamarin.com/show_bug.cgi?id=54148 CTParagraphStyle float properties have the incorrect float return type, the headers state this API's returns CGFloats (aka nfloat) instead of floats this used to work ok fetching them due to there is no difference in size for 32 bits devices but once 64 bit devices appeared the API began to fail The actual method that fetches the values `CTParagraphStyleGetValueForSpecifier` asks for the size of the returned data and we used to give the size of a float which is incorrect in 64 bits devices and the API call just correctly returned false because it could not write back the value to us. Added tests for the full properties available on CTParagraphStyle * Add comment about the weird Dispose method implementation in CreateFromSettings
spouliot
pushed a commit
that referenced
this pull request
Apr 10, 2017
…es bug 54148. (#1975) (#1980) * [CoreText] Fix bug 54148 - CoreText.CTParagraphStyle does not pick up settings from CTParagraphStyleSettings https://bugzilla.xamarin.com/show_bug.cgi?id=54148 CTParagraphStyle float properties have the incorrect float return type, the headers state this API's returns CGFloats (aka nfloat) instead of floats this used to work ok fetching them due to there is no difference in size for 32 bits devices but once 64 bit devices appeared the API began to fail The actual method that fetches the values `CTParagraphStyleGetValueForSpecifier` asks for the size of the returned data and we used to give the size of a float which is incorrect in 64 bits devices and the API call just correctly returned false because it could not write back the value to us. Added tests for the full properties available on CTParagraphStyle * Add comment about the weird Dispose method implementation in CreateFromSettings
VincentDondain
added a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Sep 18, 2019
New commits in xamarin/maccore: * xamarin/maccore@486ad67875 [device-builds] Fix if condition typo (double `[`) (dotnet#1985) * xamarin/maccore@fda32707a7 [tests] Update (and hopefully simplify) submission tests documentation wrt cerficates/profiles expiration (dotnet#1972) * xamarin/maccore@f23cd3a194 Merge pull request dotnet#1977 from xamarin/swift-o-matic-protocol-list-enum-factory * xamarin/maccore@aaa2bec8da Enum factory test * xamarin/maccore@d3c7890df2 Merge pull request dotnet#1974 from xamarin/swift-o-matic-protocol-list-enum * xamarin/maccore@436a376ab4 [provisioning-profiles] Add 'Developer ID Application' and 'Developer ID Installer' certificates. (dotnet#1975) * xamarin/maccore@ddc68fc899 Support for protocol list types in enum payloads. Diff: https://github.com/xamarin/maccore/compare/4611683312fd8ad4eb2b2c093e43a5f71405bdee..486ad67875db90261f3c9818380b979db3094946
VincentDondain
added a commit
that referenced
this pull request
Sep 19, 2019
New commits in xamarin/maccore: * xamarin/maccore@486ad67875 [device-builds] Fix if condition typo (double `[`) (#1985) * xamarin/maccore@fda32707a7 [tests] Update (and hopefully simplify) submission tests documentation wrt cerficates/profiles expiration (#1972) * xamarin/maccore@f23cd3a194 Merge pull request #1977 from xamarin/swift-o-matic-protocol-list-enum-factory * xamarin/maccore@aaa2bec8da Enum factory test * xamarin/maccore@d3c7890df2 Merge pull request #1974 from xamarin/swift-o-matic-protocol-list-enum * xamarin/maccore@436a376ab4 [provisioning-profiles] Add 'Developer ID Application' and 'Developer ID Installer' certificates. (#1975) * xamarin/maccore@ddc68fc899 Support for protocol list types in enum payloads. Diff: https://github.com/xamarin/maccore/compare/4611683312fd8ad4eb2b2c093e43a5f71405bdee..486ad67875db90261f3c9818380b979db3094946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.xamarin.com/show_bug.cgi?id=54148
CTParagraphStyle float properties have the incorrect float return type,
the headers state this API's returns CGFloats (aka nfloat) instead of floats
this used to work ok fetching them due to there is no difference in size
for 32 bits devices but once 64 bit devices appeared the API began to fail
The actual method that fetches the values
CTParagraphStyleGetValueForSpecifierasks for the size of the returned data and we used to give the size of a float
which is incorrect in 64 bits devices and the API call just correctly returned
false because it could not write back the value to us.
Added tests for the full properties available on CTParagraphStyle