[mmp] Add support for linking only the platform (Xamarin.Mac.dll) assembly on the full profile - #1990
Conversation
…embly on the full profile Replace dotnet#1973 expect that the test parts are still needed.
|
@VincentDondain ^ this will require an update to the Mac addin UI (for |
|
Build success |
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
Looks great. Let me build this with my tests locally and see how it shakes out.
|
Build success |
spouliot
added
the
requires-qa-before-merge
|
I'll create a card for QA to test this |
|
Building at least a few large mac samples (SourceWriter, etc) in XM 4.5 (Full) and with --linkplatform in mmp args would be grand. |
| } | ||
| } | ||
| }, | ||
| { "linkplatform", "Link only the Xamarin.Mac.dll platform assembly", v => App.LinkMode = LinkMode.Platform }, |
There was a problem hiding this comment.
What about XamMac.dll? Do we want to support Classic? We might want to disallow it, just to minimize the test matrix.
There was a problem hiding this comment.
Not a bad point. Let me add an error...
- Extended test infrastructure change to allow classic projects that include bundling - Setting linkplatform in MonoBundlingExtraArgs since we don't even read project setting LinkMode - Platform for classic
|
Build success |
| // Warning MM2016 Invalid TlsProvider `{0}` option. The only valid value `{1}` will be used. | ||
| // MM2017 Could not process XML description: {0} | ||
| // MM202x Binding Optimizer failed processing `...`. | ||
| // MM2100 Xamarin.Mac Classic API does not support Platofmr Linking. |
There was a problem hiding this comment.
Fixed in merge with master. Thanks!
|
Master merged but not built locally. Waiting for bots to chew on it. |
|
Build failure |
|
@chamons merge issue ? all tests fails to build due to
|
|
Yep. On it (also got another conflict). Too many tests, which is a good problem. |
|
Build failure |
|
Build success |
|
Build success |
6 participants
Replace #1973 expect that
the test parts are still needed.