Skip to content

[runtime] Fix lookup of assembly in default location in framework. - #1998

Merged
rolfbjarne merged 1 commit into
dotnet:masterfrom
rolfbjarne:fix-assembly-lookup-in-framework
Apr 12, 2017
Merged

[runtime] Fix lookup of assembly in default location in framework.#1998
rolfbjarne merged 1 commit into
dotnet:masterfrom
rolfbjarne:fix-assembly-lookup-in-framework

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

No description provided.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@spouliot spouliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did it work? needs backport to d15-2 ?

@rolfbjarne

Copy link
Copy Markdown
Member Author

I ran into this with the embeddinator; usually mtouch will hardcode a mapping of assembly => location which means this code path was not hit before.

@rolfbjarne

Copy link
Copy Markdown
Member Author

That means a d15-2 backport is not necessary.

@rolfbjarne
rolfbjarne merged commit 337feb6 into dotnet:master Apr 12, 2017
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Oct 1, 2019
New commits in xamarin/maccore:

* xamarin/maccore@3e141c6779 [devops] Fix xcode11 provisioning (dotnet#2003)
* xamarin/maccore@86662c6050 Merge pull request dotnet#1999 from xamarin/swift-o-matic-doc-object-modeling
* xamarin/maccore@50822d35b3 Object Modeling documentation
* xamarin/maccore@f50226a11f Merge pull request dotnet#1998 from xamarin/swift-o-matic-doc-outline
* xamarin/maccore@d18f9ca2da functional outline documentation

Diff: https://github.com/xamarin/maccore/compare/454248ba1325b5395ee459fff05c66bb7211e835..3e141c6779fe3d0d76f6960ed0e3edb729374f78
@rolfbjarne rolfbjarne mentioned this pull request Oct 1, 2019
dalexsoto pushed a commit that referenced this pull request Oct 1, 2019
New commits in xamarin/maccore:

* xamarin/maccore@3e141c6779 [devops] Fix xcode11 provisioning (#2003)
* xamarin/maccore@86662c6050 Merge pull request #1999 from xamarin/swift-o-matic-doc-object-modeling
* xamarin/maccore@50822d35b3 Object Modeling documentation
* xamarin/maccore@f50226a11f Merge pull request #1998 from xamarin/swift-o-matic-doc-outline
* xamarin/maccore@d18f9ca2da functional outline documentation

Diff: https://github.com/xamarin/maccore/compare/454248ba1325b5395ee459fff05c66bb7211e835..3e141c6779fe3d0d76f6960ed0e3edb729374f78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants