Skip to content

[AVKit] Update to Xcode 9 beta 1 - #2206

Merged
dalexsoto merged 2 commits into
dotnet:xcode9from
dalexsoto:avkitb1
Jun 13, 2017
Merged

[AVKit] Update to Xcode 9 beta 1#2206
dalexsoto merged 2 commits into
dotnet:xcode9from
dalexsoto:avkitb1

Conversation

@dalexsoto

Copy link
Copy Markdown
Member

No description provided.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

Comment thread src/avkit.cs
[Field ("AVKitMetadataIdentifierPlaybackProgress")]
NSString PlaybackProgress { get; }

[TV (11,0)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that under a tvOS only define ?

@dalexsoto dalexsoto Jun 11, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

[Static]
[NoiOS, TV (10,1), NoWatch, NoMac]
interface AVKitMetadataIdentifier {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

Comment thread src/avkit.cs Outdated
[Export ("updatesNowPlayingInfoCenter")]
bool UpdatesNowPlayingInfoCenter { get; set; }

[iOS (11, 0)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment [iOS (11,0)] is prettier (note: you're sometimes not adding a space in this diff).

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@dalexsoto
dalexsoto merged commit 3cb3fc6 into dotnet:xcode9 Jun 13, 2017
@dalexsoto
dalexsoto deleted the avkitb1 branch June 13, 2017 23:03
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants