[net11.0] Add ReadyToRun support for CoreCLR - #24327
Conversation
- Introduced ReadyToRun configuration in Xamarin.Shared.Sdk.props. - Updated bundler environment variables in Xamarin.Shared.Sdk.targets to support ReadyToRun. - Added host_runtime_contract.h to the build process in Makefile. - Updated coreclr-bridge.m and runtime.m for R2R image handling and logging. - Updated runtime.h to reflect changes in the xamarin_pinvoke_override function signature.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #b3e5e42] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #b3e5e42] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #b3e5e42] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [CI Build #b3e5e42] Tests on macOS X64 - Mac Sonoma (14) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build #b3e5e42] Tests on macOS arm64 - Mac Sequoia (15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build #b3e5e42] Tests on macOS M1 - Mac Monterey (12) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build #b3e5e42] Tests on macOS arm64 - Mac Tahoe (26) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build #b3e5e42] Tests on macOS M1 - Mac Ventura (13) failed ❌Failed tests are:
Pipeline on Agent |
| "PINVOKE_OVERRIDE", | ||
| #endif | ||
| "TRUSTED_PLATFORM_ASSEMBLIES", | ||
| "NATIVE_DLL_SEARCH_DIRECTORIES", |
There was a problem hiding this comment.
Why is NATIVE_DLL_SEARCH_DIRECTORIES removed? It doesn't look related to R2R (it's also removed for Mono).
There was a problem hiding this comment.
We should revert that. I see it’s used for P/Invoke path resolution. I tried to reduce the scope when testing R2R and it wasn't needed for the MAUI sample.
|
Closing in favor of #24437. |
Description
This PR adds ReadyToRun support for CoreCLR. The changes from dotnet/runtime#121824 must be included in the VMR for this to work.
Changes
Fixes dotnet/runtime#120052