[net11.0] [dotnet-linker] Add a trimmer step to inline calls to Class.GetHandle[Intrinsic].#25422
[net11.0] [dotnet-linker] Add a trimmer step to inline calls to Class.GetHandle[Intrinsic].#25422rolfbjarne wants to merge 19 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #9bce624] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 154 tests failed, 40 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ framework tests2 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ fsharp tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ interdependent-binding-projects tests4 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ introspection tests3 tests failed, 6 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests32 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)21 tests failed, 3 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)24 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)21 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)24 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests🔥 Failed catastrophically on VSTS: test results - windows (no summary found). Html Report (VSDrops) Download ❌ xcframework tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sonoma (14) tests5 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests5 tests failed, 0 tests passed.Failed tests
|
9bce624 to
4682803
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #4682803] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 148 tests failed, 49 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ framework tests2 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ fsharp tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ interdependent-binding-projects tests4 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ introspection tests3 tests failed, 6 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests32 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)21 tests failed, 3 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)24 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)14 tests failed, 7 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)24 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ xcframework tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sonoma (14) tests5 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests5 tests failed, 0 tests passed.Failed tests
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ting the Class.GetHandle rewriter.
This comment has been minimized.
This comment has been minimized.
… separate target The _PostTrimmingProcessing target always runs (no Inputs/Outputs) and unconditionally recompiles inlined-class-gethandle.m even when the source file hasn't changed. This produces a newer .o file which triggers _LinkNativeExecutable to re-link the native executable, invalidating the code signature on every incremental build. Fix by splitting the CompileNativeCode invocation into a new _CompilePostTrimmingFiles target with proper Inputs/Outputs, so the .o file is only regenerated when the .m source actually changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…Outputs
When _TouchR2ROutputs touches .o files to prevent crossgen2 re-runs, it must
also touch the downstream framework/dylib outputs. Otherwise the .o files
become newer than the framework outputs, causing _CreateR2RModuleFrameworks
to unnecessarily re-link, which destroys the code signature.
Also update the CustomizedCodeSigning test to not assert on the specific
secondary codesign error message, since it differs between MonoRuntime
("code object is not signed at all") and CoreCLR ("bundle format
unrecognized"). The important assertion is "replacing existing signature"
which confirms the executable was not re-linked.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…owserEngineCore classes.
✅ [PR Build #921d505] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #921d505] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #921d505] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #d9703ff] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 193 tests passed. Failures❌ interdependent-binding-projects tests [attempt 3]2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
DO NOT REVIEW
This PR is only to get CI results.