[devops] If SYSTEM_PULLREQUEST_PULLREQUESTNUMBER is set, always use that as the PR number.#25517
[devops] If SYSTEM_PULLREQUEST_PULLREQUESTNUMBER is set, always use that as the PR number.#25517rolfbjarne wants to merge 1 commit into
Conversation
…hat as the PR number. There's no need to try to figure out which PR we're working on, if we're told by using the SYSTEM_PULLREQUEST_PULLREQUESTNUMBER environment variable.
There was a problem hiding this comment.
Pull request overview
This PR updates the DevOps GitHub automation PowerShell module to prefer Azure DevOps’ SYSTEM_PULLREQUEST_PULLREQUESTNUMBER environment variable as the authoritative PR number when it’s available, avoiding unnecessary PR discovery logic.
Changes:
- Fix a typo in an internal comment (“evirtoment” → “environment”).
- Update
Get-GitHubPRsForHashto immediately return the PR number fromSYSTEM_PULLREQUEST_PULLREQUESTNUMBERwhen set, instead of querying GitHub or inferring PR IDs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #3f16305] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #3f16305] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #3f16305] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #3f16305] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 55 tests failed, 128 tests passed. Failures❌ fsharp tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ introspection tests4 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (iOS)11 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)18 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)18 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ xcframework tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
There's no need to try to figure out which PR we're working on, if we're told
by using the SYSTEM_PULLREQUEST_PULLREQUESTNUMBER environment variable.