[Don't Merge][ModelIO] Adds Xcode 9 Beta 1 to Beta 6 bindings - #2651
Closed
dalexsoto wants to merge 3 commits into
Closed
[Don't Merge][ModelIO] Adds Xcode 9 Beta 1 to Beta 6 bindings#2651dalexsoto wants to merge 3 commits into
dalexsoto wants to merge 3 commits into
Conversation
…uble4x4). The following types will be used by ModelIO bindings
xtro and intro are clean
Contributor
|
Build failure |
rolfbjarne
requested changes
Sep 12, 2017
rolfbjarne
left a comment
rolfbjarne
left a comment
Member
There was a problem hiding this comment.
All manual bindings should have tests (ideally all generated bindings that uses a simd matrix/vector type too, I've found many bugs doing that as well).
Member
Author
|
Thanks Rolf, will close and create a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please just review commit 2b9182f this is based on PR #2632 which is awaiting resolution.