Skip to content

[AVFoundation] Use Simd-matrix for API that needs it. - #2658

Closed
rolfbjarne wants to merge 1 commit into
dotnet:xcode9from
rolfbjarne:xcode9-avfoundation-matrix
Closed

[AVFoundation] Use Simd-matrix for API that needs it.#2658
rolfbjarne wants to merge 1 commit into
dotnet:xcode9from
rolfbjarne:xcode9-avfoundation-matrix

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Sep 12, 2017

Copy link
Copy Markdown
Member

This also requires implementing the corresponding matrix (MatrixFloat4x3).

Fixes this xtro issue:

!unknown-simd-type-in-signature! OpenTK.Matrix3 AVFoundation.AVCameraCalibrationData::get_GetIntrinsicMatrix(): the native signature has a simd type (matrix_float3x3), while the corresponding managed method is using an incorrect (non-simd) type.

This also requires implementing the corresponding matrix (MatrixFloat4x3).

Fixes this xtro issue:

> !unknown-simd-type-in-signature! OpenTK.Matrix3 AVFoundation.AVCameraCalibrationData::get_GetIntrinsicMatrix(): the native signature has a simd type (matrix_float3x3), while the corresponding managed method is using an incorrect (non-simd) type.
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rolfbjarne rolfbjarne added the do-not-merge Do not merge this pull request label Sep 12, 2017
@rolfbjarne

rolfbjarne commented Sep 12, 2017

Copy link
Copy Markdown
Member Author

dont-merge until decision is made in PR #2632 about how we want the matrix types implemented.

@rolfbjarne

Copy link
Copy Markdown
Member Author

I'll create a new PR for this.

@rolfbjarne rolfbjarne closed this Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants