[uikit] Update for Xcode 9 GM - #2670
Merged
Merged
Conversation
spouliot
reviewed
Sep 12, 2017
| [Export ("bounds")] | ||
| CGRect Bounds { get; } | ||
|
|
||
| [Watch (4,0), TV (11,0), iOS (11,0)] |
Contributor
There was a problem hiding this comment.
is that type included in watchOS ?
Contributor
There was a problem hiding this comment.
not it's not in watchOS headers, let's remove it to avoid confusion
Contributor
Author
There was a problem hiding this comment.
Yea and actually all that code is under a #if !WATCH I didn't see...
dalexsoto
approved these changes
Sep 12, 2017
spouliot
suggested changes
Sep 13, 2017
| [Export ("bounds")] | ||
| CGRect Bounds { get; } | ||
|
|
||
| [Watch (4,0), TV (11,0), iOS (11,0)] |
Contributor
There was a problem hiding this comment.
not it's not in watchOS headers, let's remove it to avoid confusion
VincentDondain
force-pushed
the
uikit-gm
branch
from
September 13, 2017 02:49
624cda2 to
cb2c785
Compare
Contributor
|
Build failure |
rolfbjarne
approved these changes
Sep 13, 2017
Contributor
|
Build failure |
Member
|
Test failures are unrelated (xammac password failure - bug #58394). |
spouliot
approved these changes
Sep 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.