Skip to content

[WIP][Tests] Reenable dns tests on the watch. - #2674

Merged
spouliot merged 1 commit into
dotnet:xcode9from
mandel-macaque:reenable-watchos-dns-tests
Sep 14, 2017
Merged

[WIP][Tests] Reenable dns tests on the watch.#2674
spouliot merged 1 commit into
dotnet:xcode9from
mandel-macaque:reenable-watchos-dns-tests

Conversation

@mandel-macaque

Copy link
Copy Markdown
Contributor

No description provided.

@mandel-macaque mandel-macaque added the do-not-merge Do not merge this pull request label Sep 12, 2017
@mandel-macaque

Copy link
Copy Markdown
Contributor Author

Ran tests locally, worked but might be pure luck. Letting bots work to see the output.

@dalexsoto

Copy link
Copy Markdown
Member

#Courage 👍

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

@spouliot Looks like it was an issue with the simulator on apples side or something of the kind. I though about it when I saw the sim inclusion on the watch, probably, they got something wrong in the betas. If you are ok, we can land this.

@spouliot

Copy link
Copy Markdown
Contributor

build

@spouliot

Copy link
Copy Markdown
Contributor

let's try it a 2nd time before hitting wrench

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

Thos failures are related to the mac => https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/4965/Test_Report/

We could try another build, to see if the watch is ok. If it is the case, I'm inclined to land this. @rolfbjarne @spouliot comments?

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

build

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Sep 13, 2017
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

Exact same error in the mac, nothing to do with the watch:
https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/4966/Test_Report/

@spouliot
spouliot merged commit 9b9ffa2 into dotnet:xcode9 Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants