[arkit] Update for Xcode 9 GM - #2681
Conversation
rolfbjarne
left a comment
rolfbjarne
left a comment
There was a problem hiding this comment.
One minor thing, otherwise 👍.
| [Export ("vertexCount")] | ||
| nuint VertexCount { get; } | ||
|
|
||
| // @property (readonly, nonatomic) const vector_float3 * _Nonnull vertices; |
There was a problem hiding this comment.
This comment can be removed.
There was a problem hiding this comment.
Yup missed. I'll remove in next PR.
There was a problem hiding this comment.
@rolfbjarne that's minor though, not PR blocking, I'll fix in next PR.
|
|
||
| [iOS (11,0)] | ||
| [NoWatch, NoTV, NoMac] | ||
| [BaseType (typeof(ARLightEstimate))] |
There was a problem hiding this comment.
base type has a [DisableDefaultCtor] so the subclass should too
There was a problem hiding this comment.
You're right ARDirectionalLightEstimate subclass doesn't have init
|
|
||
| [iOS (11,0)] | ||
| [NoWatch, NoTV, NoMac] | ||
| [BaseType (typeof(ARConfiguration))] |
There was a problem hiding this comment.
there's a [DisableDefaultCtor] on the base type
but in this case it might be valid but...
The abstract base class for AR session configurations. https://developer.apple.com/documentation/arkit/arconfiguration
so there's an [Abstract] missing from ARConfiguration
There was a problem hiding this comment.
ARConfiguration should indeed be [Abstract] and [DisableDefaultCtor] is right here (:
/** Unavailable */
- (instancetype)init NS_UNAVAILABLE;
+ (instancetype)new NS_UNAVAILABLE;
|
Build success |
40c56b7 to
21c724f
Compare
| [iOS (11,0)] | ||
| [NoWatch, NoTV, NoMac] | ||
| [BaseType (typeof(ARConfiguration))] | ||
| [DisableDefaultCtor] |
There was a problem hiding this comment.
Sorry if it was confusing ;-)
but in this case it might be valid but...
meant that I did not knew if init made sense - because the base type did not have it but was abstract
It turns out it's valid
https://developer.apple.com/documentation/arkit/arorientationtrackingconfiguration/2923556-init?language=objc
There was a problem hiding this comment.
Ah sorry I misinterpreted that and thought you checked (:
| [iOS (11,0)] | ||
| [NoWatch, NoTV, NoMac] | ||
| [BaseType (typeof(ARConfiguration))] | ||
| [DisableDefaultCtor] |
There was a problem hiding this comment.
double check headers/doc - I suspect it's available
There was a problem hiding this comment.
| [iOS (11,0)] | ||
| [NoWatch, NoTV, NoMac] | ||
| [BaseType (typeof (ARConfiguration))] | ||
| [DisableDefaultCtor] |
There was a problem hiding this comment.
double check headers/doc - I suspect it's available
|
Build failure |
|
Build failure |
|
aborted build after 4 hours |
|
build |
|
Build success |
5 participants
No description provided.