[arkit] Add ARBlendShapeLocationOptions strong dictionary - #2696
Merged
Conversation
dalexsoto
reviewed
Sep 14, 2017
| [Export ("initWithBlendShapes:")] | ||
| IntPtr Constructor (NSDictionary<NSString, NSNumber> blendShapes); | ||
| */ | ||
| IntPtr Constructor (NSDictionary blendShapes); |
Contributor
Author
There was a problem hiding this comment.
It's trying to use NSObjectFlag otherwise.
spouliot
suggested changes
Sep 14, 2017
| float NoseSneerRight { get; set; } | ||
| } | ||
|
|
||
| [iOS (11,0)] |
Contributor
There was a problem hiding this comment.
Use [Internal] so this leaves us the option to expose it as a smart enum later (at the cost of extra manual code or generator changes).
Contributor
Author
There was a problem hiding this comment.
Yes good idea, thanks.
Contributor
|
Build failure |
rolfbjarne
approved these changes
Sep 14, 2017
dalexsoto
approved these changes
Sep 14, 2017
Contributor
|
Build success |
spouliot
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose to not transform those
ARBlendShapeLocationconstants ([Field]) into a smart enum because a strong dictionary is what the APIs need most.