Use correct namespace for async debugging helpers. Fixes #59015 - #2704
Use correct namespace for async debugging helpers. Fixes #59015#2704marek-safar wants to merge 1 commit into
Conversation
|
Build failure |
|
This should include the get_ObjectIdForDebugger () method as well. |
|
Build failure |
1 similar comment
|
Build failure |
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
Let's add some unit tests this time as this is a regression of https://bugzilla.xamarin.com/show_bug.cgi?id=55037
|
Its not a regression, the problem happens on android now. |
|
@vargaz "[iOS]error: * Assertion at /Users/builder/data/lanes/4691/6bea7a5b/source/xamarin-macios/external/mono/mono/mini/debugger-agent.c:4712, condition `array->len == 1' not met while debugging async methods" from VERIFIED/FIXED from https://bugzilla.xamarin.com/show_bug.cgi?id=55037 sounds very close to "2017-08-24 17:01:29.365 sampleSIGABRT.iOS[1952:392599] error: * Assertion at /Users/builder/data/lanes/5143/80f17b0b/source/xamarin-macios/external/mono/mono/mini/debugger-agent.c:4714, condition `array->len == 1' not met" from https://bugzilla.xamarin.com/show_bug.cgi?id=59015 even if it seems (from the code) that it was never really fixed (but it did went thru all the process steps) |
Replace dotnet#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] dotnet#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
|
PR #2782 does the same but adds unit tests |
…015 (#2782) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
…015 (dotnet#2782) Replace dotnet#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] dotnet#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
…015 (#2782) (#2788) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
6 participants
No description provided.