Fix netstd2 issue on XM full by expanding facades the same as Modern - #2731
Merged
Conversation
chamons
commented
Sep 20, 2017
Contributor
- The idea is to force Full and Modern to expand facades the same way. That way, we get the same, working behavior.
- f79f2e4 was not sufficient, even though it matched XI, because of the difference between XI (and Modern) and what Full was doing.
- f79f2e4 was not sufficient
chamons
requested review from
VincentDondain,
emaf,
jstedfast,
kzu and
rolfbjarne
as code owners
September 20, 2017 17:44
rolfbjarne
reviewed
Sep 20, 2017
rolfbjarne
left a comment
Member
There was a problem hiding this comment.
Do you have a test for this?
Contributor
Author
|
Yes, but they are disabled due to https://bugzilla.xamarin.com/show_bug.cgi?id=53164 |
rolfbjarne
approved these changes
Sep 20, 2017
VincentDondain
approved these changes
Sep 20, 2017
Contributor
|
Build failure |
emaf
approved these changes
Sep 20, 2017
Member
|
I would add to the commit message, that |
radical
approved these changes
Sep 20, 2017
Contributor
Author
|
Also add link to https://bugzilla.xamarin.com/show_bug.cgi?id=59474 |
jstedfast
approved these changes
Sep 21, 2017
Contributor
Author
|
Test failure: https://bugzilla.xamarin.com/show_bug.cgi?id=59654 |
chamons
added a commit
to chamons/xamarin-macios
that referenced
this pull request
Sep 27, 2017
…otnet#2731) - https://bugzilla.xamarin.com/show_bug.cgi?id=59474 - The idea is to force Full and Modern to expand facades the same way. That way, we get the same, working behavior. - f79f2e4 was not sufficient, even though it matched XI, because of the difference between XI (and Modern) and what Full was doing. - Some context: PR dotnet#2685 And that was problematic because it was expanding the netstandard facades from `Microsoft.NET.Build.Extensions` in the `ImplicitlyExpandNETStandardFacades` target. But we want to build against XM's bundled facades *only*. So we disable the ns facades completely by setting `$(ImplicitlyExpandNETStandardFacades) = false`. But now we are in the situation where a XM/Full project referencing a ns project might fail to build because of a missing `netstandard.dll` reference! And this same case was fixed for XM/Modern projects in dotnet#2643 . So, we enable the use of that for XM/Full projects too through `Xamarin.Mac.msbuild.targets`.
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 27, 2018
Context: #1154 This PR brings in changes from dotnet/macios#2643 and dotnet/macios#2731 to improve our .NET Standard support. While this does not fix the packaging problem in #1154 it will give us parity with the iOS code base.
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 27, 2018
Context: #1154 This PR brings in changes from dotnet/macios#2643 and dotnet/macios#2731 to improve our .NET Standard support. While this does not fix the packaging problem in #1154 it will give us parity with the iOS code base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.