-
Notifications
You must be signed in to change notification settings - Fork 575
[Fix] Add missing CoreData selectors. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool as long as they don't do string pointer comparisons (it'd have to be NSString if so).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, in the tests I have the following and passes:
So AFAIK we can use a managed string.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pasting the gutter conversation:
Chris Hamons @chamons 18:15
well so that works, but that isn't exactly what i mean
in some corners of Cocoa, you have to pass in a "known" identifier
and so you go myThing = SomeGlobalThing
and as opposed to actually doing a string compare, they just compare the pointer of that global to you identifier
so if you round trip NSString -> C# string -> NSString it doesn't work
but identifier seems ok, i don't see any constants you need to shove in
(don't know this API)
Manuel de la Pena @mandel-macaque 18:17
@chamons the API does not work like that, you are passing the renaming of a property, so you have model X, witha property Y, then you update the object to rename Y to Z and that RenamingProperty allows to do the match
Chris Hamons @chamons 18:17
then you are safe and get my
Manuel de la Pena @mandel-macaque 18:17
@chamons is like, hey this is a property that used to be called Manuel, but now is Pedro