Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/Xamarin.MacDev
19 changes: 12 additions & 7 deletions msbuild/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ IOS_BINDING_TARGETS = $(wildcard Xamarin.ObjcBinding.Tasks/*.targets)
IOS_TASK_ASSEMBLIES = \
Xamarin.iOS.Tasks \
Xamarin.iOS.Tasks.Core \
Xamarin.MacDev.Tasks \
Xamarin.MacDev.Tasks.Core \
Xamarin.iOSDev.Tasks \
Xamarin.iOSDev.Tasks.Core \

IOS_TASK_REFERENCE_ASSEMBLIES = \
Xamarin.MacDev
Xamarin.iOSDev

IOS_DIRECTORIES = \
$(IOS_DESTDIR)$(MONOTOUCH_PREFIX)/lib/mono/Xamarin.iOS \
Expand Down Expand Up @@ -326,17 +326,22 @@ $(foreach dll,$(MSBUILD_TASK_ASSEMBLIES),$(dll)/bin/$(CONFIG)/$(dll).dll): .buil
.PHONY: $(MSBUILD_SYMLINKS)

# Xamarin.MacDev.dll comes from the Xamarin.MacDev repository
# Newtonsoft.Json.dll comes from a NuGet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide QA a list of tasks that required Newtonsoft.Json.dll so they can make sure the changes are tested correctly ?

$(foreach dll,$(sort $(MSBUILD_REFERENCE_ASSEMBLIES)),build/$(notdir $(dll)).dll): .build-stamp | build
$(Q) cp Xamarin.MacDev.Tasks.Core/bin/$(CONFIG)/$(notdir $@) $@

define copyToBuild
build/$(1).dll: $(1)/bin/$(CONFIG)/$(1).dll | build
define copyiOSToBuild
build/$(1).dll: Xamarin.iOS.Tasks/bin/$(CONFIG)/$(1).dll | build
$$(Q) cp $$< $$@
endef

define copyMacToBuild
build/$(1).dll: Xamarin.Mac.Tasks/bin/$(CONFIG)/$(1).dll | build
$$(Q) cp $$< $$@
endef

# Create the rules to copy all the dlls into the 'build' directory.
$(foreach dll,$(sort $(MSBUILD_TASK_ASSEMBLIES)),$(eval $(call copyToBuild,$(dll))))
$(foreach dll,$(sort $(IOS_TASK_ASSEMBLIES)),$(eval $(call copyiOSToBuild,$(dll))))
$(foreach dll,$(sort $(MAC_TASK_ASSEMBLIES)),$(eval $(call copyMacToBuild,$(dll))))

# this is a directory-creating target.
$(MSBUILD_DIRECTORIES) build:
Expand Down
120 changes: 120 additions & 0 deletions msbuild/Xamarin.MacDev.Tasks.Core/Xamarin.iOSDev.Tasks.Core.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<ProductVersion>8.0.30703</ProductVersion>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>{FDE6C2CD-DF58-4E8f-8F81-E4D05B0B8796}</ProjectGuid>
<OutputType>Library</OutputType>
<RootNamespace>Xamarin.MacDev.Tasks</RootNamespace>
<AssemblyName>Xamarin.iOSDev.Tasks.Core</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug</OutputPath>
<DefineConstants>DEBUG;MONO_DATACONVERTER_PUBLIC</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<Optimize>true</Optimize>
<OutputPath>bin\Release</OutputPath>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>MONO_DATACONVERTER_PUBLIC</DefineConstants>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="Microsoft.Build.Engine" />
<Reference Include="Microsoft.Build.Framework" />
<Reference Include="Microsoft.Build.Tasks.v4.0" />
<Reference Include="Microsoft.Build.Utilities.v4.0" />
<Reference Include="System.Core" />
<Reference Include="System.Xml" />
<Reference Include="Mono.Posix" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Json" />
<Reference Include="System.Runtime.Serialization" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\external\Xamarin.MacDev\Xamarin.MacDev\Xamarin.iOSDev.csproj">
<Project>{78A5AB67-6EC5-4035-8820-337D7D6430AE}</Project>
<Name>Xamarin.iOSDev</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<!-- XBuild does not define the MSBuildRuntimeVersion property. -->
<Compile Include="MsBuildTasks\MoveTaskBase.cs" Condition="'$(MSBuildRuntimeVersion)' != ''" />
<Compile Include="MsBuildTasks\XBuildMoveTaskBase.cs" Condition="'$(MSBuildRuntimeVersion)' == ''" />
</ItemGroup>
<ItemGroup>
<Compile Include="MsBuildTasks\CopyBase.cs" />
<Compile Include="MsBuildTasks\DeleteBase.cs" />
<Compile Include="MsBuildTasks\ExecBase.cs" />
<Compile Include="MsBuildTasks\MakeDirBase.cs" />
<Compile Include="MsBuildTasks\RemoveDirBase.cs" />
<Compile Include="MsBuildTasks\TouchBase.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="Tasks\ACToolTaskBase.cs" />
<Compile Include="Tasks\ArchiveTaskBase.cs" />
<Compile Include="Tasks\ArToolTaskBase.cs" />
<Compile Include="Tasks\BTouchTaskBase.cs" />
<Compile Include="Tasks\CodesignTaskBase.cs" />
<Compile Include="Tasks\CodesignVerifyTaskBase.cs" />
<Compile Include="Tasks\CompileAppManifestTaskBase.cs" />
<Compile Include="Tasks\ComputeBundleResourceOutputPathsTaskBase.cs" />
<Compile Include="Tasks\CollectBundleResourcesTaskBase.cs" />
<Compile Include="Tasks\CollectFrameworksBase.cs" />
<Compile Include="Tasks\CompileEntitlementsTaskBase.cs" />
<Compile Include="Tasks\CompileSceneKitAssetsTaskBase.cs" />
<Compile Include="Tasks\CreateAssetPackManifestTaskBase.cs" />
<Compile Include="Tasks\CreateEmbeddedResourcesTaskBase.cs" />
<Compile Include="Tasks\CreateInstallerPackageTaskBase.cs" />
<Compile Include="Tasks\CreatePkgInfoTaskBase.cs" />
<Compile Include="Tasks\DetectSigningIdentityTaskBase.cs" />
<Compile Include="Tasks\DittoTaskBase.cs" />
<Compile Include="Tasks\DSymUtilTaskBase.cs" />
<Compile Include="Tasks\FindItemWithLogicalNameTaskBase.cs" />
<Compile Include="Tasks\GenerateBundleNameTaskBase.cs" />
<Compile Include="Tasks\GetNativeExecutableNameTaskBase.cs" />
<Compile Include="Tasks\GetPropertyListValueTaskBase.cs" />
<Compile Include="Tasks\IBToolTaskBase.cs" />
<Compile Include="Tasks\MetalLibTaskBase.cs" />
<Compile Include="Tasks\MetalTaskBase.cs" />
<Compile Include="Tasks\OptimizePropertyListTaskBase.cs" />
<Compile Include="Tasks\PackLibraryResourcesTaskBase.cs" />
<Compile Include="Tasks\PrepareNativeReferencesTaskBase.cs" />
<Compile Include="Tasks\PropertyListEditorTaskBase.cs" />
<Compile Include="Tasks\ScnToolTaskBase.cs" />
<Compile Include="Tasks\ReadItemsFromFileBase.cs" />
<Compile Include="Tasks\WriteItemsToFileBase.cs" />
<Compile Include="Tasks\SmartCopyTaskBase.cs" />
<Compile Include="Tasks\SpotlightIndexerTaskBase.cs" />
<Compile Include="Tasks\SymbolStripTaskBase.cs" />
<Compile Include="Tasks\TextureAtlasTaskBase.cs" />
<Compile Include="Tasks\UnpackLibraryResourcesTaskBase.cs" />
<Compile Include="Tasks\XcodeCompilerToolTask.cs" />
<Compile Include="Tasks\XcodeToolTaskBase.cs" />
<Compile Include="Tasks\ZipTaskBase.cs" />
<Compile Include="AssetPackUtils.cs" />
<Compile Include="BundleResource.cs" />
<Compile Include="DataConverter.cs" />
<Compile Include="LinkTarget.cs" />
<Compile Include="LoggingExtensions.cs" />
<Compile Include="NativeReferenceKind.cs" />
<Compile Include="PathUtils.cs" />
<Compile Include="ProcessArgumentBuilder.cs" />
<Compile Include="ProcessUtils.cs" />
<Compile Include="StringParserService.cs" />
<Compile Include="PlatformFramework.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
</Project>
14 changes: 13 additions & 1 deletion msbuild/Xamarin.MacDev.Tasks.sln
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.iOS.Tasks.Tests", "
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.MacDev", "..\external\Xamarin.MacDev\Xamarin.MacDev\Xamarin.MacDev.csproj", "{CC3D9353-20C4-467A-8522-A9DED6F0C753}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.MacDev.Tasks", "Xamarin.MacDev.Tasks\Xamarin.MacDev.Tasks.csproj", "{534D7C5A-0E1C-4C58-9E48-21B1A98919EB}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.iOSDev.Tasks", "Xamarin.MacDev.Tasks\Xamarin.iOSDev.Tasks.csproj", "{534D7C5A-0E1C-4C58-9E48-21B1A98919EB}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.Mac.Tasks", "Xamarin.Mac.Tasks\Xamarin.Mac.Tasks.csproj", "{C8D98DC1-5122-4B10-A152-17196C7BD9AC}"
EndProject
Expand All @@ -19,6 +19,10 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.MacDev.Tasks.Core",
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.Mac.Tasks.Core", "Xamarin.Mac.Tasks.Core\Xamarin.Mac.Tasks.Core.csproj", "{AF1AC7C3-F6DD-4E46-B897-9DBB90B158EC}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.iOSDev", "..\external\Xamarin.MacDev\Xamarin.MacDev\Xamarin.iOSDev.csproj", "{78A5AB67-6EC5-4035-8820-337D7D6430AE}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xamarin.iOSDev.Tasks.Core", "Xamarin.MacDev.Tasks.Core\Xamarin.iOSDev.Tasks.Core.csproj", "{FDE6C2CD-DF58-4E8F-8F81-E4D05B0B8796}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -57,6 +61,14 @@ Global
{AF1AC7C3-F6DD-4E46-B897-9DBB90B158EC}.Debug|Any CPU.Build.0 = Debug|Any CPU
{AF1AC7C3-F6DD-4E46-B897-9DBB90B158EC}.Release|Any CPU.ActiveCfg = Debug|Any CPU
{AF1AC7C3-F6DD-4E46-B897-9DBB90B158EC}.Release|Any CPU.Build.0 = Debug|Any CPU
{78A5AB67-6EC5-4035-8820-337D7D6430AE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{78A5AB67-6EC5-4035-8820-337D7D6430AE}.Debug|Any CPU.Build.0 = Debug|Any CPU
{78A5AB67-6EC5-4035-8820-337D7D6430AE}.Release|Any CPU.ActiveCfg = Release|Any CPU
{78A5AB67-6EC5-4035-8820-337D7D6430AE}.Release|Any CPU.Build.0 = Release|Any CPU
{FDE6C2CD-DF58-4E8F-8F81-E4D05B0B8796}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{FDE6C2CD-DF58-4E8F-8F81-E4D05B0B8796}.Debug|Any CPU.Build.0 = Debug|Any CPU
{FDE6C2CD-DF58-4E8F-8F81-E4D05B0B8796}.Release|Any CPU.ActiveCfg = Release|Any CPU
{FDE6C2CD-DF58-4E8F-8F81-E4D05B0B8796}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
93 changes: 93 additions & 0 deletions msbuild/Xamarin.MacDev.Tasks/Xamarin.iOSDev.Tasks.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<ProductVersion>8.0.30703</ProductVersion>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>{534D7C5A-0E1C-4C58-9E48-21B1A98919EB}</ProjectGuid>
<OutputType>Library</OutputType>
<RootNamespace>Xamarin.MacDev.Tasks</RootNamespace>
<AssemblyName>Xamarin.iOSDev.Tasks</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\Debug</OutputPath>
<DefineConstants>DEBUG;MONO_DATACONVERTER_PUBLIC</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<Optimize>true</Optimize>
<OutputPath>bin\Release</OutputPath>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<ConsolePause>false</ConsolePause>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>MONO_DATACONVERTER_PUBLIC</DefineConstants>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="Microsoft.Build.Engine" />
<Reference Include="Microsoft.Build.Framework" />
<Reference Include="Microsoft.Build.Tasks.v4.0" />
<Reference Include="Microsoft.Build.Utilities.v4.0" />
<Reference Include="System.Core" />
<Reference Include="System.Xml" />
<Reference Include="Mono.Cecil, Version=0.9.5.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756">
<Private>True</Private>
<HintPath Condition=" Exists('..\..\packages\Mono.Cecil.0.9.5.0\lib\net40\Mono.Cecil.dll') ">..\..\packages\Mono.Cecil.0.9.5.0\lib\net40\Mono.Cecil.dll</HintPath>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's also an assembly that can change between versions
and can include breaking changes (it's happening with mono 5.8)

</Reference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\external\Xamarin.MacDev\Xamarin.MacDev\Xamarin.iOSDev.csproj">
<Project>{78A5AB67-6EC5-4035-8820-337D7D6430AE}</Project>
<Name>Xamarin.iOSDev</Name>
</ProjectReference>
<ProjectReference Include="..\Xamarin.MacDev.Tasks.Core\Xamarin.iOSDev.Tasks.Core.csproj">
<Project>{FDE6C2CD-DF58-4E8f-8F81-E4D05B0B8796}</Project>
<Name>Xamarin.iOSDev.Tasks.Core</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Compile Include="MsBuildTasks\Copy.cs" />
<Compile Include="MsBuildTasks\Delete.cs" />
<Compile Include="MsBuildTasks\Exec.cs" />
<Compile Include="MsBuildTasks\MakeDir.cs" />
<Compile Include="MsBuildTasks\Move.cs" />
<Compile Include="MsBuildTasks\RemoveDir.cs" />
<Compile Include="MsBuildTasks\Touch.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="Tasks\ArTool.cs" />
<Compile Include="Tasks\Codesign.cs" />
<Compile Include="Tasks\CollectBundleResources.cs" />
<Compile Include="Tasks\ComputeBundleResourceOutputPaths.cs" />
<Compile Include="Tasks\CreateAssetPackManifest.cs" />
<Compile Include="Tasks\CreateInstallerPackage.cs" />
<Compile Include="Tasks\CreatePkgInfo.cs" />
<Compile Include="Tasks\Ditto.cs" />
<Compile Include="Tasks\DSymUtil.cs" />
<Compile Include="Tasks\FindItemWithLogicalName.cs" />
<Compile Include="Tasks\GenerateBundleName.cs" />
<Compile Include="Tasks\GetNativeExecutableName.cs" />
<Compile Include="Tasks\GetPropertyListValue.cs" />
<Compile Include="Tasks\PackLibraryResources.cs" />
<Compile Include="Tasks\PropertyListEditor.cs" />
<Compile Include="Tasks\SmartCopy.cs" />
<Compile Include="Tasks\SpotlightIndexer.cs" />
<Compile Include="Tasks\SymbolStrip.cs" />
<Compile Include="Tasks\UnpackLibraryResources.cs" />
<Compile Include="Tasks\WriteItemsToFile.cs" />
<Compile Include="Tasks\ReadItemsFromFile.cs" />
<Compile Include="Tasks\Zip.cs" />
</ItemGroup>
<ItemGroup>
<None Include="packages.config" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Copyright (C) 2015-2016 Xamarin Inc. All rights reserved.

<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<UsingTask TaskName="Xamarin.iOS.Tasks.BTouch" AssemblyFile="..\iOS\Xamarin.iOS.Tasks.dll" />
<UsingTask TaskName="Xamarin.MacDev.Tasks.Zip" AssemblyFile="..\iOS\Xamarin.MacDev.Tasks.dll" />
<UsingTask TaskName="Xamarin.MacDev.Tasks.Zip" AssemblyFile="..\iOS\Xamarin.iOSDev.Tasks.dll" />

<Import Project="$(MSBuildThisFileDirectory)$(MSBuildThisFileName).Before.targets"
Condition="Exists('$(MSBuildThisFileDirectory)$(MSBuildThisFileName).Before.targets')"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Copyright (C) 2014 Xamarin Inc. All rights reserved.

<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<UsingTask TaskName="Xamarin.iOS.Tasks.BTouch" AssemblyFile="$(MSBuildThisFileDirectory)..\iOS\Xamarin.iOS.Tasks.dll" />
<UsingTask TaskName="Xamarin.MacDev.Tasks.Zip" AssemblyFile="$(MSBuildThisFileDirectory)..\iOS\Xamarin.MacDev.Tasks.dll" />
<UsingTask TaskName="Xamarin.MacDev.Tasks.Zip" AssemblyFile="$(MSBuildThisFileDirectory)..\iOS\Xamarin.iOSDev.Tasks.dll" />

<Import Project="$(MSBuildThisFileDirectory)$(MSBuildThisFileName).Before.targets"
Condition="Exists('$(MSBuildThisFileDirectory)$(MSBuildThisFileName).Before.targets')"/>
Expand Down
Loading