Skip to content

[AVFoundation] Add missing categories from Xcode 9 and add new API from Xcode 9.1 #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 4 commits into from
Oct 30, 2017
Merged

[AVFoundation] Add missing categories from Xcode 9 and add new API from Xcode 9.1 #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db7794e
[AVFoundation] Add missing categories from Xcode 9 and add new API fr…
mandel-macaque Oct 24, 2017
d8bef4e
Addresses review comments. Added missinf attr, Get* to those methods …
mandel-macaque Oct 25, 2017
ea156eb
Remove not correct use of async attr. Add missing smart enum property.
mandel-macaque Oct 25, 2017
ab9f2c5
Updated bidings as per reviews. Mainly added NoMac when possible and …
mandel-macaque Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/AVFoundation/AudioRendererWasFlushedAutomaticallyEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#if !WATCH
using XamCore.Foundation;
using XamCore.CoreMedia;
using XamCore.ObjCRuntime;

namespace XamCore.AVFoundation {

[TV (11, 0), NoWatch, Mac (10, 13), iOS (11, 0)]
public partial class AudioRendererWasFlushedAutomaticallyEventArgs {
public CMTime AudioRendererFlushTime {
get {
return _AudioRendererFlushTime.CMTimeValue;
}
}
}
}
#endif
15 changes: 14 additions & 1 deletion src/AVFoundation/Enums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,9 @@ public enum AVCaptureSessionInterruptionReason : nint {
VideoDeviceNotAvailableInBackground = 1,
AudioDeviceInUseByAnotherClient = 2,
VideoDeviceInUseByAnotherClient = 3,
VideoDeviceNotAvailableWithMultipleForegroundApps = 4
VideoDeviceNotAvailableWithMultipleForegroundApps = 4,
[iOS (11, 1)]

@spouliot spouliot Oct 24, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoMac, NoTV and NoWatch missing

@mandel-macaque mandel-macaque Oct 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already has a [NoTV, NoWatch] in the top of the enum and it is inside a #if !MONOMAC which means that is not necessary, right?

@dalexsoto dalexsoto Oct 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah technically it is not needed but I think it was the plan that at some point we would get rid of those conditionals if possible so having that metadata there won't hurt I guess, unless @spouliot says otherwise :)

@VincentDondain VincentDondain Oct 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd get rid of #if !MONOMAC, not of availability attributes on the parent (so lack of [NoTV, NoWatch] still valid).

We could just add a [NoMac] to public enum AVCaptureSessionInterruptionReason but that would be just noise in this case, better do it for things we add.

@spouliot spouliot Oct 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k, we'll soon have xtro results so it will be easier to spot them :)

@mandel-macaque mandel-macaque Oct 27, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, leaving as it is to reduce noise in the diff. We can do this later for new types or in a pr just to get rid of the #if !MONOMAC

VideoDeviceNotAvailableDueToSystemPressure = 5,
}

[iOS (9,0)]
Expand Down Expand Up @@ -977,4 +979,15 @@ public enum AVDepthDataQuality : nint {
Low = 0,
High = 1
}

[NoWatch, NoTV, NoMac, iOS (11,1)]
[Flags]
[Native]
public enum AVCaptureSystemPressureFactors : nuint
{
None = 0,
SystemTemperature = (1 << 0),
PeakPower = (1 << 1),
DepthModuleTemperature = (1 << 2)
}
}
Loading