Skip to content

Bump mono & Touch.Unit - #3560

Merged
spouliot merged 2 commits into
dotnet:masterfrom
lewurm:bump-mono-4adf8229e88ffeed60a9b63d402e9d074323f13b
Feb 22, 2018
Merged

Bump mono & Touch.Unit#3560
spouliot merged 2 commits into
dotnet:masterfrom
lewurm:bump-mono-4adf8229e88ffeed60a9b63d402e9d074323f13b

Conversation

@lewurm

@lewurm lewurm commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

Commit list for mono/mono:

* mono/mono@4adf8229e88 bump nunit-lite (dotnet#7139)
* mono/mono@de4729fae29 [mono-api-html] Expand "ignore" functionality (dotnet#7154)
* mono/mono@721462c4a15 [2017-12] [corlib] Fix RuntimeFeatureTest.NoNewFeaturesAdded on mobile (dotnet#7152)

Diff: mono/mono@177997b...4adf822
@lewurm
lewurm requested a review from spouliot February 21, 2018 16:46
@lewurm

lewurm commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

this should, hopefully, fix the issue with nunitlite that we have seen.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot

Copy link
Copy Markdown
Contributor

@lewurm we're back to the older issue

	Unhandled Exception:
	System.NullReferenceException: Object reference not set to an instance of an object
	  at NUnitLite.Runner.ResultSummary.Visit (NUnit.Framework.Api.ITestResult result) [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/ResultSummary.cs:140 
	  at NUnitLite.Runner.ResultSummary..ctor (NUnit.Framework.Api.ITestResult result) [0x00006] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/ResultSummary.cs:52 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.InitializeXmlFile (NUnit.Framework.Api.ITestResult result) [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:109 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.WriteXmlOutput (NUnit.Framework.Api.ITestResult result, System.Xml.XmlWriter xmlWriter) [0x00007] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:102 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.WriteResultFile (NUnit.Framework.Api.ITestResult result, System.IO.TextWriter writer) [0x0000e] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:90 
	  at MonoTouch.NUnit.NUnitOutputTextWriter.Close () [0x000bc] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/NUnitOutputTextWriter.cs:99 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.CloseWriter () [0x0006c] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:354 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.Run () [0x0003f] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:173 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.<AutoRun>b__40_0 () [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:139 
	  at MonoTouch.NUnit.UI.TouchRunner+<>c__DisplayClass19_0.<ExecuteOnMainThread>b__0 () [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:685 
	  at Foundation.NSAsyncActionDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/11.11.0.17/src/Xamarin.iOS/Foundation/NSAction.cs:125 

https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/6442/Test_Report/

that bump'ing back solved

@spouliot spouliot added the do-not-merge Do not merge this pull request label Feb 21, 2018
@lewurm

lewurm commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

I forgot to bump Touch.Unit

Commit list for spouliot/Touch.Unit:

* xamarin/Touch.Unit@4ac4e32 [TouchRunner] do not use FinallyDelegate in Runner, because it requires remoting API to be available (dotnet#49)

Diff: xamarin/Touch.Unit@b5b227e...4ac4e32
@lewurm lewurm changed the title Bump mono Bump mono & Touch.Unit Feb 21, 2018
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot

Copy link
Copy Markdown
Contributor

issues are unrelated -> https://github.com/xamarin/maccore/issues/647
RE is aware

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Feb 22, 2018
@spouliot
spouliot merged commit 4cab7b2 into dotnet:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants