[jenkins] Clean keystore on bots before running tests - #3754
Merged
Conversation
Because if invalid data gets into the store then some unit tests will always fail on that particular bot. Fix https://github.com/xamarin/maccore/issues/640
Contributor
Author
|
Need to be run on xam-mac-mini-1 to confirm the issue is solved |
dalexsoto
approved these changes
Mar 15, 2018
chamons
approved these changes
Mar 15, 2018
rolfbjarne
approved these changes
Mar 15, 2018
Contributor
|
Build success |
Contributor
Author
|
we got lucky |
rolfbjarne
pushed a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 12, 2018
Because if invalid data gets into the store then some unit tests will always fail on that particular bot. Fix xamarin/maccore#640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because if invalid data gets into the store then some unit tests
will always fail on that particular bot.
Fix https://github.com/xamarin/maccore/issues/640