[mk] Put shell code in shell scripts and add support for switching between different remotes for dependencies. - #4060
Merged
rolfbjarne merged 1 commit intoMay 10, 2018
Conversation
…tween different remotes for dependencies. Put the shell code for resetting README dependencies in a shell script instead of embedded in the Makefile so that it's easier to write, read and debug. Also add support for switching between different remotes for README dependencies (this means that `make reset-X` will now work fine if `X`'s remote changed). A side effect is that all README dependencies will now end up with a 'xamarin' remote in addition to the 'origin' remote, but this should have no other effect.
spouliot
approved these changes
May 9, 2018
Contributor
Build failure
|
Member
Author
|
Test failure is a known issue: https://github.com/xamarin/maccore/issues/581 |
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 13, 2018
…tween different remotes for dependencies. (dotnet#4060) Put the shell code for resetting README dependencies in a shell script instead of embedded in the Makefile so that it's easier to write, read and debug. Also add support for switching between different remotes for README dependencies (this means that `make reset-X` will now work fine if `X`'s remote changed). A side effect is that all README dependencies will now end up with a 'xamarin' remote in addition to the 'origin' remote, but this should have no other effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the shell code for resetting README dependencies in a shell script instead
of embedded in the Makefile so that it's easier to write, read and debug.
Also add support for switching between different remotes for README
dependencies (this means that
make reset-Xwill now work fine ifX'sremote changed).
A side effect is that all README dependencies will now end up with a 'xamarin'
remote in addition to the 'origin' remote, but there should be no other
side effects.