Skip to content

[d15-7] Fix default values for touchbar APIs in NSTextViewDelegate. (#3843) - #4071

Merged
chamons merged 1 commit into
dotnet:d15-7from
chamons:d15-7-touchbar-fix
May 14, 2018
Merged

[d15-7] Fix default values for touchbar APIs in NSTextViewDelegate. (#3843)#4071
chamons merged 1 commit into
dotnet:d15-7from
chamons:d15-7-touchbar-fix

Conversation

@chamons

@chamons chamons commented May 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@chamons chamons added do-not-merge Do not merge this pull request macOS Issues affecting macOS labels May 10, 2018
@chamons
chamons requested a review from dalexsoto as a code owner May 10, 2018 15:21
@chamons chamons changed the title Fix default values for touchbar APIs in NSTextViewDelegate. (#3843) [d15-7] Fix default values for touchbar APIs in NSTextViewDelegate. (#3843) May 10, 2018
@alanmcgovern

Copy link
Copy Markdown
Contributor

Fix verified :)

@chamons

chamons commented May 10, 2018

Copy link
Copy Markdown
Contributor Author

#4074

@chamons chamons added requires-qa-before-merge The pull request requires QA to approve it before it can be merged and removed do-not-merge Do not merge this pull request labels May 10, 2018
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build comment file:

Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only)
Generator Diff
🔥 Test run failed 🔥

Test results

5 tests failed, 75 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug: Crashed
  • monotouch-test/tvOS - simulator/Debug: BuildFailure
  • framework-test/tvOS - simulator/Debug: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build comment file:

Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only)
Generator Diff
Test run succeeded


@GLjackyvaswani

Copy link
Copy Markdown

Hello ,
Following is the status :-
We have gone through the bug #3824 and downloaded the Archive.zip sample attached with this issue.
Archive.zip download link :- Archive.zip

Build taken from :-
https://bosstoragemirror.azureedge.net/wrench/macios-mac-master/41/4176ca56b15286d66a48b5e5ca327dd830d6887a/xamarin.ios-11.11.0.108.pkg

https://bosstoragemirror.azureedge.net/wrench/macios-mac-master/41/4176ca56b15286d66a48b5e5ca327dd830d6887a/xamarin.mac-4.5.0.108.pkg

Build Info:-
Visual Studio Enterprise 2017 for Mac Version 7.5 (build 1254)
Xamarin.Mac
Version: 4.5.0.108 (Visual Studio Enterprise)
Xamarin.iOS Version: 11.11.0.108 (Visual Studio Enterprise)
Hash: 4176ca5 Branch: master

Scenarion 1:-
Steps followed for verification :-
1 . Opened the Archive.zip sample in VSFM
2 . Build the application and deploy

Observations :-
1 . On deploying sample it has two text fields , so have entered the text using Mac touch bar , in both the text fields I am able to add the text successfully and IDE does not crash.

Scenario 2 :-
1 . Created Mac sample
2 . Double click on Main.story board it opens in Xcode
3 . Add text fields in view controller and save it
4 . Close Xcode and refresh the project in VSFM

Observations :- On deploying the app , it contains the text field , in which we are able to add text using Mac Touch Bar without IDE getting crashed.

Detailed build Information :-
https://gist.github.com/p-lad/803c42f0963a5dfcfaaaf4ed78e92204

Screen cast link :-
https://www.screencast.com/t/gmTaG8jJEoX

As , IDE crash is not observed , marking this bug as QA Approved
Thanks.

@slluis

slluis commented May 14, 2018

Copy link
Copy Markdown

So, can this be merged? I need a build asap.

@chamons
chamons merged commit eeaeb7e into dotnet:d15-7 May 14, 2018
@chamons
chamons deleted the d15-7-touchbar-fix branch May 14, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS Issues affecting macOS requires-qa-before-merge The pull request requires QA to approve it before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants