Skip to content

[jenkins] Improve api/generator diff reporting to say if there were changes, and if they were breaking or not. #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 11 commits into from
May 30, 2018
Merged

[jenkins] Improve api/generator diff reporting to say if there were changes, and if they were breaking or not. #4138

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
56ae68f
[jenkins] Improve api/generator diff reporting to say if there were c…
rolfbjarne May 25, 2018
2fc086c
Merge remote-tracking branch 'origin/master' into jenkins-descriptive…
rolfbjarne May 29, 2018
7922f65
Fix detection of breaking changes.
rolfbjarne May 29, 2018
7691d28
Fix merge problems.
rolfbjarne May 29, 2018
074ed4b
INTRODUCE BREAKING CHANGE
rolfbjarne May 29, 2018
1ebbaa3
Introduce generator change.
rolfbjarne May 29, 2018
a9d6915
Revert "Introduce generator change."
rolfbjarne May 30, 2018
680b438
Revert "INTRODUCE BREAKING CHANGE"
rolfbjarne May 30, 2018
c32acf5
Add non-breaking API.
rolfbjarne May 30, 2018
dd36808
[compare] More advanced script block removal.
rolfbjarne May 30, 2018
3d0421e
Revert "Add non-breaking API."
rolfbjarne May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions jenkins/compare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,20 @@ cp -R tools/comparison/apidiff/diff jenkins-results/apicomparison/
cp tools/comparison/apidiff/*.html jenkins-results/apicomparison/
cp -R tools/comparison/generator-diff jenkins-results/generator-diff

printf "✅ [API Diff (from PR only)](%s/API_20diff_20_28PR_20only_29)\\n" "$BUILD_URL" >> "$WORKSPACE/jenkins/pr-comments.md"
printf "✅ [Generator Diff](%s/Generator_20Diff)\\n" "$BUILD_URL" >> "$WORKSPACE/jenkins/pr-comments.md"
printf "✅ [API Diff (from PR only)](%s/API_20diff_20_28PR_20only_29)" "$BUILD_URL" >> "$WORKSPACE/jenkins/pr-comments.md"
if ! grep "href=" jenkins-results/apicomparison/api-diff.html >/dev/null 2>&1; then
printf " (no change)" >> "$WORKSPACE/jenkins/pr-comments.md"
elif perl -0777 -pe 's/<script type="text\/javascript">.*?<.script>/script removed/gs' jenkins-results/apicomparison/*.html | grep data-is-breaking; then
printf " (🔥 breaking changes 🔥)" >> "$WORKSPACE/jenkins/pr-comments.md"
else
printf " (please review changes)" >> "$WORKSPACE/jenkins/pr-comments.md"
fi
printf "\\n" >> "$WORKSPACE/jenkins/pr-comments.md"

printf "✅ [Generator Diff](%s/Generator_20Diff)" "$BUILD_URL" >> "$WORKSPACE/jenkins/pr-comments.md"
if grep "^[+-][^+-]" jenkins-results/generator-diff/generator.diff | grep -v "^.[[]assembly: AssemblyInformationalVersion" | grep -v "^[+-][[:space:]]*internal const string Revision =" >/dev/null 2>&1; then
printf " (please review changes)" >> "$WORKSPACE/jenkins/pr-comments.md"
else
printf " (only version changes)" >> "$WORKSPACE/jenkins/pr-comments.md"
fi
printf "\\n" >> "$WORKSPACE/jenkins/pr-comments.md"