[jenkins] Fix scripts to be shellcheck-happy. - #4148
Merged
Conversation
A few general categories of fixes: * Sprinkle lots of quotes everywhere. * Don't use environment variables in the format string to printf, instead pass them as arguments. * Don't use backticks to execute commands (it's deprecated), use the new "$(...)" syntax instead.
spouliot
approved these changes
May 29, 2018
Contributor
Build success
|
dalexsoto
approved these changes
May 29, 2018
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 12, 2018
A few general categories of fixes: * Sprinkle lots of quotes everywhere. * Don't use environment variables in the format string to printf, instead pass them as arguments. * Don't use backticks to execute commands (it's deprecated), use the new "$(...)" syntax instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few general categories of fixes: