[jenkins] Cherry-pick a series of fixes for internal jenkins support from the d15-8 branch - #4195
Merged
Merged
Conversation
Quoting empty CONFIGURE_FLAGS ends up doing this:
./configure "" --disable-ios-device
and since configure parses arguments until it finds an empty argument, it
would stop parsing at the first argument, effectively not disabling the device
build.
So don't quote CONFIGURE_FLAGS when invoking configure. shellcheck doesn't
quite like this, but the better code is much more complex, and not really
needed, so just add an exception.
spouliot
approved these changes
Jun 7, 2018
Contributor
Build success
|
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Jun 12, 2018
…from the d15-8 branch (dotnet#4195) * [Jenkins] Create artifacts.json and set a GH status as 'Jenkins: Artifacts'. * [jenkins] Include the url in artifacts.json * [jenkins] Add sha256 checksum to artifacts.json as well. * [Jenkins] Enable xamarin before provisioning so that we auto-provision Xcode. * [jenkins] Fix passing flags to configure. Quoting empty CONFIGURE_FLAGS ends up doing this: ./configure "" --disable-ios-device and since configure parses arguments until it finds an empty argument, it would stop parsing at the first argument, effectively not disabling the device build. So don't quote CONFIGURE_FLAGS when invoking configure. shellcheck doesn't quite like this, but the better code is much more complex, and not really needed, so just add an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of fixes for internal Jenkins support were implemented on the d15-8
branch (in PR #4180); this PR is cherry-picking those fixes to master.
[jenkins] Fix passing flags to configure.
Quoting empty CONFIGURE_FLAGS ends up doing this:
and since configure parses arguments until it finds an empty argument, it
would stop parsing at the first argument, effectively not disabling the
device build.
So don't quote CONFIGURE_FLAGS when invoking configure. shellcheck doesn't
quite like this, but the better code is much more complex, and not really
needed, so just add an exception.
[Jenkins] Enable xamarin before provisioning so that we auto-provision Xcode.
[jenkins] Add sha256 checksum to artifacts.json as well.
[jenkins] Include the url in artifacts.json
[Jenkins] Create artifacts.json and set a GH status as 'Jenkins: Artifacts'.