Skip to content

[jenkins] Use different emojiis depending on the result of the api/generator diffs. - #4240

Merged
rolfbjarne merged 1 commit into
dotnet:masterfrom
rolfbjarne:differentiate-diff-with-emojiis
Jun 13, 2018
Merged

[jenkins] Use different emojiis depending on the result of the api/generator diffs.#4240
rolfbjarne merged 1 commit into
dotnet:masterfrom
rolfbjarne:differentiate-diff-with-emojiis

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Makes it harder to accidentially skip reviewing changes.

…nerator diffs.

Makes it harder to accidentially skip reviewing changes.
@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build comment file:

Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (only version changes)
Test run succeeded


@spouliot spouliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: it might have been fixed by backports but I noticed that (at least xcode10 branch) links do not point to the reports (only jenkins)

@rolfbjarne

Copy link
Copy Markdown
Member Author

@spouliot

note: it might have been fixed by backports but I noticed that (at least xcode10 branch) links do not point to the reports (only jenkins)

This will be fixed in PR #4224.

@rolfbjarne
rolfbjarne merged commit 4b707d9 into dotnet:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants