Skip to content

Bump to mono:2018-06 - #4277

Merged
spouliot merged 41 commits into
masterfrom
mono-2018-06
Oct 10, 2018
Merged

Bump to mono:2018-06#4277
spouliot merged 41 commits into
masterfrom
mono-2018-06

Conversation

@directhex

@directhex directhex commented Jun 15, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@directhex
directhex requested a review from rolfbjarne as a code owner June 15, 2018 16:44
@directhex directhex added run-all-tests Run all our tests. enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) labels Jun 15, 2018
@rolfbjarne rolfbjarne added skip-device-tests do-not-merge Do not merge this pull request labels Jun 15, 2018
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build comment file:

🔥 Build failed 🔥


@spouliot

Copy link
Copy Markdown
Contributor

PR failed while building mono

19:08:41 libtool: install: chmod 644 /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/sdks/out/ios-sim64-release/lib/libMonoSupportW.a
19:08:41 libtool: install: ranlib -no_warning_for_no_symbols /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/sdks/out/ios-sim64-release/lib/libMonoSupportW.a
19:08:41 cp ../external/mono/sdks/builds/ios-sim64-release/config.h /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/builds/install/simulator64/include/mono-2.0
19:08:41 cp ../external/mono/sdks/builds/ios-sim64-release/mono/eglib/eglib-config.h /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/builds/install/simulator64/include/mono-2.0
19:08:41 make: *** [all-recurse] Error 1

@marek-safar marek-safar mentioned this pull request Jul 10, 2018
13 tasks
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build was aborted

🔥 Build failed 🔥

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build was aborted

🔥 Build failed 🔥

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build was aborted

@monojenkins

Copy link
Copy Markdown
Contributor

@monojenkins

Copy link
Copy Markdown
Contributor

@monojenkins

Copy link
Copy Markdown
Contributor

@monojenkins

Copy link
Copy Markdown
Contributor

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
🔥 Test run failed 🔥

Test results

# Test run in progress: InProgress, Waiting: 1, Building: 4, BuildQueued: 85, Built: 62, RunQueued: 50, Succeeded: 22, Failed: 1, Ignored: 1124

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 6)

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

* [mtouch] add --interp-mixed option

When enabling this option, mtouch will AOT compile `mscorlib.dll`.  At
runtime that means every method that wasn't AOT'd will be executed by
the runtime interpreter.

* [mtouch] Add support to --interpreter to list the assemblies to (not) interpret.

* [msbuild] Simplify interpreter code to use a single variable.

* Fix whitespace.

* [mtouch] Move mtouch-specific code to mtouch-specific file.

* [msbuild] An empty string is a valid value for 'Interpreter', so make it a non-required property.

* [mtouch] Add sanity check for aot-compiling interpreted assemblies.
@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
Test run succeeded

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

2 tests failed, 0 tests skipped, 223 tests passed.

Failed tests

  • System/iOS Unified 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS - simulator/Release (all optimizations): Failed

@marek-safar

Copy link
Copy Markdown
Contributor

@spouliot could we get this in now when you have separate 15.9 branch to unblock us on PRs which depend on this one?

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
Test run succeeded

@spouliot

Copy link
Copy Markdown
Contributor

@marek-safar yeah, I don't like long-running PR either. However that would break master must be releasable and SDK must ship identical mono. Also we are close to branch for the next milestone and I'd rather not run into the same 15.9 situation again.

How close are we wrt XA and 2018-06 ?

@marek-safar

Copy link
Copy Markdown
Contributor

Unfortunately, I don't know how long before the code is in XA, we have only about 13 tests failures (not serious) but I have no idea when @jonpryor is going to merge it.

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
Test run succeeded

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.11'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.11 failed (xammac_tests)

Build succeeded
API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.
🔥 Xamarin.Mac tests on macOS 10.11 failed (xammac_tests) 🔥

@spouliot

spouliot commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

@chamons have you seen the NSRangeException error before ? very likely unrelated to the merge (since the previous one was fine)

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
Test run succeeded

@chamons

chamons commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

I have not, but it completely looks like a "random failure". Filed as https://github.com/xamarin/maccore/issues/1084

The last test listed is a CloudKit test, so I could see some async \ network causing wonky test behavior.

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Oct 10, 2018
@spouliot
spouliot merged commit 6f2ebed into master Oct 10, 2018
@taikodragon

Copy link
Copy Markdown

When might we see this in VS / VS4M?

@chamons

chamons commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

@taikodragon Since this has just landed in master, it wouldn't be until the 16.x timeframe.

You can read about the VS release schedule here, and there are no announced dates currently, but thinking on the order of months would be reasonable.

@chamons
chamons deleted the mono-2018-06 branch October 10, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) run-all-tests Run all our tests. skip-api-comparison Skips API / generator diffs when testing pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.