Skip to content

[d16-0] Bump Xamarin.MacDev to get fix for #5277. - #5284

Merged
rolfbjarne merged 1 commit into
d16-0from
issue-5277-bump-d16-0
Dec 19, 2018
Merged

[d16-0] Bump Xamarin.MacDev to get fix for #5277.#5284
rolfbjarne merged 1 commit into
d16-0from
issue-5277-bump-d16-0

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Dec 17, 2018

Copy link
Copy Markdown
Member

@rolfbjarne
Bump Xamarin.MacDev to get fix for #5277.
3d97aa5 
Commit list for xamarin/Xamarin.MacDev:

* dotnet/macios-devtools@44e90a2 Keys in property list dictionaries aren't necessarily unique. Fixes xamarin-macios#5277. (#39) (#41)
* dotnet/macios-devtools@c81c625 Get rid of spurious <ItemGroup>
* dotnet/macios-devtools@d1d3fa4 Remove packagerefs. Leads to unintended problems (see discussion xamarin/md-addins#3946) (#38)

Diff: dotnet/macios-devtools@179f720...44e90a2

Fixes #5277.
@rolfbjarne rolfbjarne added run-internal-tests If tests should be executed on the internal Jenkins instance. skip-public-jenkins Completely skip execution in the public Jenkins instance labels Dec 17, 2018
@rolfbjarne rolfbjarne changed the title Bump Xamarin.MacDev to get fix for #5277. [d16-0] Bump Xamarin.MacDev to get fix for #5277. Dec 17, 2018
@rolfbjarne rolfbjarne added this to the d16-0 milestone Dec 17, 2018
@rolfbjarne rolfbjarne added the build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. label Dec 17, 2018
@xamarin-release-manager

xamarin-release-manager commented Dec 17, 2018

Copy link
Copy Markdown
Collaborator

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

2 tests failed, 0 tests skipped, 282 tests passed.

Failed tests

  • MSBuild tests/iOS: Failed (Execution failed with exit code 24)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 6)

@rolfbjarne

rolfbjarne commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

Test failures were due to #5277 (comment). I've fixed the bots according to the workaround, and re-scheduled a build.

@xamarin-release-manager

xamarin-release-manager commented Dec 18, 2018

Copy link
Copy Markdown
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)

@xamarin-release-manager

xamarin-release-manager commented Dec 18, 2018

Copy link
Copy Markdown
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2

🔥 Build failed 🔥

@xamarin-release-manager

xamarin-release-manager commented Dec 18, 2018

Copy link
Copy Markdown
Collaborator

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

2 tests failed, 0 tests skipped, 282 tests passed.

Failed tests

  • [NUnit] Mono MonoParallelTests/watchOS - simulator/Debug: Crashed
  • MSBuild tests/iOS: Failed (Execution failed with exit code 2)

@rolfbjarne

rolfbjarne commented Dec 19, 2018

Copy link
Copy Markdown
Member Author

Test failures are known issues:

@rolfbjarne
rolfbjarne merged commit 12adbf6 into d16-0 Dec 19, 2018
@rolfbjarne
rolfbjarne deleted the issue-5277-bump-d16-0 branch December 19, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@spouliot spouliot spouliot approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-public-jenkins Completely skip execution in the public Jenkins instance

Projects

None yet

Milestone

d16-0

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @xamarin-release-manager @spouliot