Skip to content

[Tests] Do not fail with timeouts. Fixes #1332 #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 1 commit into from
Feb 12, 2019
Merged

[Tests] Do not fail with timeouts. Fixes #1332 #5596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/monotouch-test/System.Net.Http/MessageHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,13 @@ public void RedirectionWithAuthorizationHeaders (Type handlerType)
}
}, () => done);

Assert.IsTrue (done, "Request timedout.");
Assert.IsTrue (containsHeaders, "Request did not reach final destination.");
Assert.IsFalse (containsAuthorizarion, $"Authorization header did reach the final destination. {json}");
Assert.IsNull (ex, $"Exception {ex} for {json}");
if (!done) { // timeouts happen in the bost due to dns issues, connection issues etc.. we do not want to fail
Assert.Inconclusive ("Request timedout.");
} else {
Assert.IsTrue (containsHeaders, "Request did not reach final destination.");
Assert.IsFalse (containsAuthorizarion, $"Authorization header did reach the final destination. {json}");
Assert.IsNull (ex, $"Exception {ex} for {json}");
}
}
}
}