[MSBuild] Fix the codesign of f# app extensions. - #5884
Conversation
We need to import the iOS common after the core f# ones to ensure they do not override the wrong ones. Fixes: dotnet#3684
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
Changes like this scare me, as they can have non-trivial consequences. I'm not saying it is wrong, but it is significantly more risky that it appears at face value.
|
@chamons tested locally, device tests should pick it up, but AFAIK works. @jstedfast is the master that found the issue to be honest, all merits should go his way |
|
@chamons what this patch does is make it such that the Xamarin.iOS.AppExtension.Common.targets correctly override the core Microsoft F# targets. When the targets are imported in the original order, the Microsoft F# targets override the iOS targets which essentially destroys the whole purpose of the iOS targets. |
|
Yeah, I got that. I think its right, but due to how msbuild orders things it can introduce larger behavior changes than the diff suggests. |
|
Since it's limited to F# extensions and those do not work right now (if I understand correctly) then I don't think it's very risky (even to backport to 16.1). |
|
Build success |
|
@monojenkins backport to d16-1 |
8 participants
We need to import the iOS common after the core f# ones to ensure they do
not override the wrong ones.
Fixes: #3684