[CFNetwork] Ensure we do not block on redirects. - #5900
Merged
mandel-macaque merged 1 commit intoApr 16, 2019
Merged
Conversation
The changes in mono are changing threading. This means that the code is getting deadlock in the ReadStreamData. This happens because we were not removing the handlers from the first requests events. Initially, before we had to take care about the auth headers, this was needed to init certain internal state for the HttpContent that was sexposed to the user. With the fix of the CVE, the first request, in case of a redirect, is garbage and is ignored. The second request is the one returned to the user and contains all the required info. Removing the event handlers, ensure that HandleClose is not called and therefore ReadStream is never called.
spouliot
approved these changes
Apr 15, 2019
Contributor
|
Build success |
Member
|
I ran the monotouch-tests on simulator on two macs, and on my iPad. All passed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in mono are changing threading. This means that the code is
getting deadlock in the ReadStreamData.
This happens because we were not removing the handlers from the first request events.
Initially, before we had to take care about the auth headers, this was needed to init
certain internal state for the HttpContent that was exposed to the
user. With the fix of the CVE, the first request, in case of a redirect,
is garbage and is ignored. The second request is the one returned to the
user and contains all the required info.
Removing the event handlers, ensure that HandleCloseEvent is not called and
therefore ReadStream is never called.