[builds] Don't reference makefiles from the mono repository when using the mono archive. - #5970
Closed
rolfbjarne wants to merge 1 commit into
Closed
Conversation
…g the mono archive. Instead of using a makefile in the mono repository to get the list facades to ship, we list the facade assemblies present in the mono archive instead. We still have a hardcoded list of facade assemblies elsewhere, and tests that checks that list against what's shipped, so any changes in the list of assemblies (unwanted or not) won't go unnoticed.
dalexsoto
approved these changes
Apr 30, 2019
spouliot
approved these changes
Apr 30, 2019
Contributor
|
Build success |
Member
Author
|
Let's wait with this until we're consuming the BCL assemblies from the mono archive again (i.e. #5971 is resolved). |
mandel-macaque
approved these changes
May 3, 2019
Member
|
Superseded by my #6097 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a makefile in the mono repository to get the list facades to
ship, we list the facade assemblies present in the mono archive instead.
We still have a hardcoded list of facade assemblies elsewhere, and tests that
checks that list against what's shipped, so any changes in the list of
assemblies (unwanted or not) won't go unnoticed.