[apidiff] Fix a few issues with the apidiff when the mono hash or api diff url changes. - #6084
Merged
rolfbjarne merged 5 commits intoMay 22, 2019
Merged
Conversation
This fixes an issue when bumping mono: when bumping mono, the already downloaded mono archive isn't applicable (because we've changed to the previous commit, which has the previous mono hash, whose archive hasn't been downloaded). So add a rule to get mono-api-info.exe and mono-api-html.exe, by downloading the current mono archive.
…ain the hash. This way the logic doesn't get confused when the hash changes (or there's an old unzip stamp in the directory), and things are downloaded again as expected.
Things end up confused if temporary files have been removed by make, but our stamp file that the temporary files are still there is present.
Contributor
|
Build success |
Member
Author
|
This isn't quite right, the api diff should be empty, not report breaking changes 😒 |
If everything that needs the bundled zip already depends on it.
This makes it less annoying when the api diff calculation changes, because with the previous behavior they were impossible to test in a PR, since any changes wouldn't take effect until after the PR was merged.
Contributor
|
Build success |
mandel-macaque
approved these changes
May 21, 2019
spouliot
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.