Add symlink that points to current mono sdks dir - #6146
Merged
Conversation
Use that instead of an msbuild variable that won't work in VSMac. Also bump maccore to get an equivalent fix there. Diff: https://github.com/xamarin/maccore/compare/34725fe136aee39a9f9984bbb508b6670654f7b3..104656b89060d3c98cdc626709f7cadc467549af
rolfbjarne
requested review from
VincentDondain,
chamons,
dalexsoto and
spouliot
as code owners
May 28, 2019 06:51
Member
Author
Contributor
|
Build failure Test results1 tests failed, 102 tests passed.Failed tests
|
mandel-macaque
approved these changes
May 28, 2019
Member
Author
|
build |
spouliot
approved these changes
May 28, 2019
dalexsoto
approved these changes
May 28, 2019
Contributor
|
Build failure Test results3 tests failed, 166 tests passed.Failed tests
|
Member
Author
|
Test failures on public Jenkins are unrelated: |
Contributor
|
known issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use that instead of an msbuild variable that won't work in VSMac.
Also bump maccore to get an equivalent fix there.
Diff: https://github.com/xamarin/maccore/compare/34725fe136aee39a9f9984bbb508b6670654f7b3..104656b89060d3c98cdc626709f7cadc467549af