Skip to content

Add symlink that points to current mono sdks dir - #6146

Merged
spouliot merged 1 commit into
masterfrom
mono-source-symlink
May 28, 2019
Merged

Add symlink that points to current mono sdks dir#6146
spouliot merged 1 commit into
masterfrom
mono-source-symlink

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Use that instead of an msbuild variable that won't work in VSMac.

Also bump maccore to get an equivalent fix there.

Diff: https://github.com/xamarin/maccore/compare/34725fe136aee39a9f9984bbb508b6670654f7b3..104656b89060d3c98cdc626709f7cadc467549af

Use that instead of an msbuild variable that won't work in VSMac.

Also bump maccore to get an equivalent fix there.

Diff: https://github.com/xamarin/maccore/compare/34725fe136aee39a9f9984bbb508b6670654f7b3..104656b89060d3c98cdc626709f7cadc467549af
@rolfbjarne

Copy link
Copy Markdown
Member Author

This is the part of #6097 that's required to make the tip of maccore to build (#6097 requires breaking changes in maccore which has already been implemented; this PR makes sure master is still buildable with the tip of maccore/master in case #6097 is delayed).

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 102 tests passed.

Failed tests

  • dont link/Mac Classic/All: BuildFailure

@rolfbjarne rolfbjarne added the run-bcl-tests Run the BCL tests label May 28, 2019
@rolfbjarne

Copy link
Copy Markdown
Member Author

build

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 166 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • [NUnit] Mono SystemJsonTests/watchOS 32-bits - simulator/Debug: Crashed
  • [xUnit] Mono SystemNetHttpUnitTestsXunit/watchOS 32-bits - simulator/Debug: Crashed

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failures on public Jenkins are unrelated:

@spouliot

Copy link
Copy Markdown
Contributor

known issues

@spouliot
spouliot merged commit 1766a8d into master May 28, 2019
@rolfbjarne
rolfbjarne deleted the mono-source-symlink branch June 11, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-bcl-tests Run the BCL tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants