Skip to content

[d16-2] [Tests] Try different urls before failing the test. #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spouliot merged 2 commits into from
Jun 12, 2019
Merged

[d16-2] [Tests] Try different urls before failing the test. #6265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9216804
[Tests] If there are network issues do not set the tests as a failure.
mandel-macaque Jun 10, 2019
283558d
Use a list of urls to try several times.
mandel-macaque Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions tests/monotouch-test/Foundation/NSDataTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,27 @@ public void Https ()
Assert.Ignore ("NSData.FromUrl doesn't seem to work in watchOS");
}
#endif
using (var url = new NSUrl ("https://www.microsoft.com/robots.txt"))
using (var x = NSData.FromUrl (url)) {
Assert.That ((x != null) && (x.Length > 0));
// we have network issues, try several urls, if one works, be happy, else fail
var urls = new string [] {
"https://www.microsoft.com/robots.txt",
"https://www.xamarin.com/robots.txt",
"http://www.bing.com/robots.txt",
"https://www.xbox.com/robots.txt",
"https://www.msn.com/robots.txt",
"https://visualstudio.microsoft.com/robots.txt",
};
for (var i = 0; i < urls.Length; i++) {
NSError error;
using (var nsUrl = new NSUrl (urls [i]))
using (var x = NSData.FromUrl (nsUrl, NSDataReadingOptions.Uncached, out error)) {
if (error != null)
continue;
Assert.That (x != null);
Assert.That (x.Length > 0);
return;
}
}
Assert.Fail ("None of the urls could be fetch.");
}

[Test]
Expand Down