Skip to content

[Tests] Ignore memory hungry tests in old devices. - #6913

Merged
mandel-macaque merged 1 commit into
dotnet:masterfrom
mandel-macaque:ignore-mem-failing-tests
Sep 5, 2019
Merged

[Tests] Ignore memory hungry tests in old devices.#6913
mandel-macaque merged 1 commit into
dotnet:masterfrom
mandel-macaque:ignore-mem-failing-tests

Conversation

@mandel-macaque

Copy link
Copy Markdown
Contributor

Related mono issue: mono/mono#16671

Was added as a comment in the ignore file.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 154 tests passed.

Failed tests

  • [xUnit] Mono SystemCoreXunit/watchOS 32-bits - simulator/Debug: Crashed

@mandel-macaque
mandel-macaque merged commit 8a4c858 into dotnet:master Sep 5, 2019
@mandel-macaque

Copy link
Copy Markdown
Contributor Author

@monojenkins backport to xcode11

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

@monojenkins backport to d16-3

@monojenkins

Copy link
Copy Markdown
Contributor

@mandel-macaque backporting to xcode11 failed, the patch results in conflicts:

Applying: [Tests] Ignore memory hungry tests in old devices.
Using index info to reconstruct a base tree...
A	tests/bcl-test/iOS-monotouch_corlib_xunit-test.dll.ignore
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tests/bcl-test/iOS-monotouch_corlib_xunit-test.dll.ignore deleted in 533cf01569c8fca6fbdb1e36c2fa3e2084bd5bf4 and modified in [Tests] Ignore memory hungry tests in old devices.. Version [Tests] Ignore memory hungry tests in old devices. of tests/bcl-test/iOS-monotouch_corlib_xunit-test.dll.ignore left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 [Tests] Ignore memory hungry tests in old devices.

Please backport manually!

mandel-macaque pushed a commit that referenced this pull request Sep 9, 2019
Included changes are:

* New Cecil API in 2019-08
* Permit new symbols from networkable AOT profiler in symbols test
* Bump Mono to include fix for zlib linking, and new Cecil API
* We need to link against zlib now, if using libmono.a
* [Tests] Ignore memory hungry tests in old devices. (#6913)
* Ignore certain tests that use too many resources in old devices.
* Add missing tests that use too much memory on 32b devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants