Skip to content

[simlauncher] Add missing weak frameworks to simlauncher - #6955

Merged
spouliot merged 1 commit into
dotnet:xcode11from
spouliot:xcode11-simlauncher-weak_frameworks
Sep 10, 2019
Merged

[simlauncher] Add missing weak frameworks to simlauncher#6955
spouliot merged 1 commit into
dotnet:xcode11from
spouliot:xcode11-simlauncher-weak_frameworks

Conversation

@spouliot

@spouliot spouliot commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Things often work fine without them but, in a few cases, you can run into
some weird problems.

Add better comments for synchronization... until we add some tests [1]

Replace the following, cancelled PR

[1] #6951

Things often work fine without them but, in a few cases, you can run into
some weird problems.

Add better comments for synchronization... until we add some tests [1]

Replace the following, cancelled PR
* BackgroundTask dotnet#6949
* INcomingCallNotifications dotnet#6954
* LinkPresentation dotnet#6953
* PencilKit dotnet#6950
* SoundAnalysis dotnet#6952

[1] dotnet#6951
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build failed or was aborted

🔥 Build failed 🔥

@spouliot

spouliot commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

known, random build issue

19:31:25 error CS0009: Metadata file '/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/mcs/class/lib/xammac_net_4_5/nunitlite.dll' could not be opened -- PE image doesn't contain managed metadata.

https://github.com/xamarin/maccore/issues/1888

@spouliot

spouliot commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

build

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@spouliot
spouliot merged commit c41a545 into dotnet:xcode11 Sep 10, 2019
@spouliot
spouliot deleted the xcode11-simlauncher-weak_frameworks branch September 10, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants