[d16-3] Bump mono to get fix for #7005. - #7017
Closed
rolfbjarne wants to merge 1 commit into
Closed
Conversation
New commits in mono/mono: * mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16896) * mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851) * mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b * mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16758) * mono/mono@4f5ed502c6e [msbuild] pick up p4 versions * mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset * mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712 Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..1648e886873298b2467d9b6afc7bc89454fceb76
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Sep 18, 2019
mandel-macaque
left a comment
mandel-macaque
left a comment
Contributor
There was a problem hiding this comment.
After running the submission tests I confirm we need the change. Once is landed I'll re-run tests.
dalexsoto
added
the
requires-approval-before-merge
spouliot
approved these changes
Sep 18, 2019
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
Note that the bump does bring a new Roslyn and msbuild
Contributor
|
removing |
Contributor
|
Build failure Test results49 tests failed, 386 tests' device not found, 101 tests passed.Failed tests
|
Member
Author
|
Test failures are unrelated (all https://github.com/xamarin/maccore/issues/581) |
Contributor
|
This did not make the bar for d16-3 release. Up for possible SR though. |
Contributor
|
looks deprecated by #7126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New commits in mono/mono:
Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..1648e886873298b2467d9b6afc7bc89454fceb76