Bump maccore for device scheduling fix - #7030
Merged
VincentDondain merged 1 commit intoSep 19, 2019
Merged
Conversation
New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
mandel-macaque
approved these changes
Sep 19, 2019
Contributor
|
Build failure Test results386 tests' device not found, 86 tests passed. |
dalexsoto
approved these changes
Sep 19, 2019
spouliot
suggested changes
Sep 19, 2019
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
🔥 Test run failed 🔥
^ should not happen
386 tests' device not found, 86 tests passed.
the device tests are normally not mentioned on the public PR and don't turn PR red
rolfbjarne
approved these changes
Sep 19, 2019
spouliot
approved these changes
Sep 19, 2019
Contributor
Author
|
Known issue with device tests on Jenkins: xamarin/maccore#1983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New commits in xamarin/maccore:
[) (Patch from Zoltan to fix build error with CppSharp.CppParser.dll (#1967) #1986)Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f