Skip to content

Drop the Xcode 9.4 dependency. - #7044

Merged
rolfbjarne merged 5 commits into
dotnet:masterfrom
rolfbjarne:drop-xcode94-dependency
Sep 24, 2019
Merged

Drop the Xcode 9.4 dependency.#7044
rolfbjarne merged 5 commits into
dotnet:masterfrom
rolfbjarne:drop-xcode94-dependency

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Sep 20, 2019

Copy link
Copy Markdown
Member

Also bump mono to get the removal of the mac32 binaries.

New commits in mono/mono:

Diff: https://github.com/mono/mono/compare/29b1ac19c961b959a09097dbc0fe4cd567cc5298..70d690305348cb30cf620db0679ba1173dc7adb0

@rolfbjarne
Drop the Xcode 9.4 dependency.
b4f4731 
Also bump mono to get the removal of the mac32 binaries.

New commits in mono/mono:

* mono/mono@70d69030534 [2019-08] [merp] Use a separate program as the hang supervisor. (dotnet#16900)
* mono/mono@4bff2b6370b [offsets-tool] Install clang into the user-specific python directory.
* mono/mono@81894ec8cad Implement WriteCore and ReadCore in DeflateStream
* mono/mono@bfbf823ca11 [ci] Remove more XCODE32_DIR usages (dotnet#16964)
* mono/mono@ce01b20a4d4 Add net_4.8.xml to EXTRA_DIST and bump binary-reference-assemblies again
* mono/mono@7a587d7fa61 Add .NET 4.8 reference assemblies (dotnet#16912)
* mono/mono@35e454a8f6a [sdks] Remove the mac32 build. (dotnet#16936)
* mono/mono@75eb342f532 [2019-08] [System] Make FileSystemWatcher backend non-static (dotnet#16926)
* mono/mono@5881981f790 [2019-08] [mini] Add missing membars when initializing rgctx entries (dotnet#16909)
* mono/mono@6290b6cd6e3 Temporarily disable embedded ppdb data decompression (dotnet#16911)
* mono/mono@a0e7f9eaf2e [2019-08] [arm64_32] make "Debug Mode" work on Watch series 4 with --interpreter (dotnet#16886)
* mono/mono@6275840a7f8 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16901)
* mono/mono@25f60932839 [corlib] Fix building nunit-lite twice (dotnet#16895)
* mono/mono@7ec17ba1be9 [2019-08] [android sdk] Add aprofutil tool (dotnet#16884)
* mono/mono@f755f3b5391 [metadata] Fix leaks when handling a few attributes (dotnet#16850)
* mono/mono@5f9a2db39b0 [2019-08] Fix infrequent hangs in test-runner. (dotnet#16854)
* mono/mono@f31f5ea1f1b [2019-08] [threads] do not convert NULL thread name (dotnet#16828)
* mono/mono@20308e6f874 [aot] Do not wrap tool_prefix path when calling strip (dotnet#16820)
* mono/mono@cecda47c489 [aprofutil] Add -p and -f options
* mono/mono@824cc12ac3f Bump to mono/corefx@e79cf5b
* mono/mono@b77dc06a7e7 [aprofutil] Install the tool correctly (dotnet#16112)
* mono/mono@1848d78d60f [aotprof-tool] Initial import of AOT profiler tool (dotnet#15384)
* mono/mono@da0086e3042 [2019-08] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16756)
* mono/mono@0297b21b030 [msbuild][roslyn] Bump msbuild and roslyn to pull in new versions (dotnet#16768)
* mono/mono@40631e3b9e3 [2019-08] [aot] move method_addresses to data.rel.so section to avoid text relocations (dotnet#16751)
* mono/mono@68b77674e20 Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712
* mono/mono@4a0b4f41ede [mini] publish global patches after JitInfo has been added
* mono/mono@7a1f63fde68 [debugger][android] It was not initialising seq_points on MonoCompile on Android, so when was compiling dynamic methods, seq_points wasn't created and we got the assert when try to single step.

Diff: https://github.com/mono/mono/compare/29b1ac19c961b959a09097dbc0fe4cd567cc5298..70d690305348cb30cf620db0679ba1173dc7adb0
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 20, 2019
@monojenkins

monojenkins commented Sep 20, 2019

Copy link
Copy Markdown
Contributor

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 148 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 7)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 3)

@rolfbjarne
[tests] Add a fat macOS dylib for testing purposes.
a04d6f0 
Add a binary version of a fat macOS dylib (because we can't create one when we
need it since we can't create 32-bit slice anymore).

It was created like this (in tests/test-libraries):

	$ cat test.m
	int theUltimateAnswer ()
	{
		return 42;
	}

	$ /Applications/Xcode94.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang test.m -olibtest.i386.dylib -shared -isysroot /Applications/Xcode94.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -framework Foundation -framework CoreLocation -lz  -arch i386
	$ lipo -create libtest.i386.dylib .libs/macos/libtest.dylib -output libtest-fat.dylib
@rolfbjarne
[tests] Adjust XM tests to XM not having fat dylibs anymore.
e92f55e
@rolfbjarne
[tests] Adjust product tests to some libraries not being fat anymore.
d922b05
@rolfbjarne
rolfbjarne requested a review from chamons as a code owner September 23, 2019 10:49
@monojenkins

monojenkins commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 149 tests passed.

Failed tests

  • mscorlib/iOS Unified 32-bits - simulator/Debug: Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)

@monojenkins

monojenkins commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 151 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

@rolfbjarne

rolfbjarne commented Sep 24, 2019

Copy link
Copy Markdown
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/581).

@rolfbjarne
rolfbjarne merged commit 2adecee into dotnet:master Sep 24, 2019
@rolfbjarne rolfbjarne mentioned this pull request Sep 24, 2019
Closed
@lewurm lewurm mentioned this pull request Sep 24, 2019
Merged
rolfbjarne added a commit that referenced this pull request Sep 30, 2019
@rolfbjarne
Drop the Xcode 9.4 dependency. (#7044)
734f057 
* Drop the Xcode 9.4 dependency.

Also bump mono to get the removal of the mac32 binaries.

New commits in mono/mono:

* mono/mono@beb9a1b182a [sdks] Remove the mac32 build.
* mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable
* mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
* mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream
* mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (#16933)
* mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (#16870)
* mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (#16910)
* mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes #7005. (#16896)
* mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (#16675) (#16851)
* mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b
* mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (#16758)
* mono/mono@4f5ed502c6e [msbuild] pick up p4 versions
* mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset
* mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes #16712

Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..beb9a1b182a14986e836864e5d555c3b5ec52ba0

* [tests] Add a fat macOS dylib for testing purposes.

Add a binary version of a fat macOS dylib (because we can't create one when we
need it since we can't create 32-bit slice anymore).

It was created like this (in tests/test-libraries):

	$ cat test.m
	int theUltimateAnswer ()
	{
		return 42;
	}

	$ /Applications/Xcode94.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang test.m -olibtest.i386.dylib -shared -isysroot /Applications/Xcode94.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -framework Foundation -framework CoreLocation -lz  -arch i386
	$ lipo -create libtest.i386.dylib .libs/macos/libtest.dylib -output libtest-fat.dylib

* [tests] Adjust XM tests to XM not having fat dylibs anymore.

* [tests] Adjust product tests to some libraries not being fat anymore.
rolfbjarne added a commit that referenced this pull request Oct 1, 2019
@rolfbjarne
Drop the Xcode 9.4 dependency. (#7044) (#7135)
4d5d38b 
* Drop the Xcode 9.4 dependency. (#7044)

* Drop the Xcode 9.4 dependency.

Also bump mono to get the removal of the mac32 binaries.

New commits in mono/mono:

* mono/mono@beb9a1b182a [sdks] Remove the mac32 build.
* mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable
* mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
* mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream
* mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (#16933)
* mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (#16870)
* mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (#16910)
* mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes #7005. (#16896)
* mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (#16675) (#16851)
* mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b
* mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (#16758)
* mono/mono@4f5ed502c6e [msbuild] pick up p4 versions
* mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset
* mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes #16712

Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..beb9a1b182a14986e836864e5d555c3b5ec52ba0

* [tests] Add a fat macOS dylib for testing purposes.

Add a binary version of a fat macOS dylib (because we can't create one when we
need it since we can't create 32-bit slice anymore).

It was created like this (in tests/test-libraries):

	$ cat test.m
	int theUltimateAnswer ()
	{
		return 42;
	}

	$ /Applications/Xcode94.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang test.m -olibtest.i386.dylib -shared -isysroot /Applications/Xcode94.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -framework Foundation -framework CoreLocation -lz  -arch i386
	$ lipo -create libtest.i386.dylib .libs/macos/libtest.dylib -output libtest-fat.dylib

* [tests] Adjust XM tests to XM not having fat dylibs anymore.

* [tests] Adjust product tests to some libraries not being fat anymore.

* [tests] Don't treat an Xcode with the same major version number as old.

Fixes an issue in the MT0091 test, where it would fail on tvOS because the
test wanted to use an older Xcode, and we could end up returning Xcode 11.0
when the current Xcode is 11.1. Since the test depends on using the OS SDK as
it was designed for (technically using an OS SDK earlier than the latest), it
ended up failing because while the iOS SDK was bumped in Xcode 11.1, the tvOS
SDK was not.
VincentDondain pushed a commit to VincentDondain/xamarin-macios that referenced this pull request Oct 16, 2019
@rolfbjarne @VincentDondain
Drop the Xcode 9.4 dependency. (dotnet#7044) (dotnet#7135)
20f75a1 
* Drop the Xcode 9.4 dependency. (dotnet#7044)

* Drop the Xcode 9.4 dependency.

Also bump mono to get the removal of the mac32 binaries.

New commits in mono/mono:

* mono/mono@beb9a1b182a [sdks] Remove the mac32 build.
* mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable
* mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
* mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream
* mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (dotnet#16933)
* mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (dotnet#16870)
* mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (dotnet#16910)
* mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16896)
* mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851)
* mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b
* mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16758)
* mono/mono@4f5ed502c6e [msbuild] pick up p4 versions
* mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset
* mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712

Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..beb9a1b182a14986e836864e5d555c3b5ec52ba0

* [tests] Add a fat macOS dylib for testing purposes.

Add a binary version of a fat macOS dylib (because we can't create one when we
need it since we can't create 32-bit slice anymore).

It was created like this (in tests/test-libraries):

	$ cat test.m
	int theUltimateAnswer ()
	{
		return 42;
	}

	$ /Applications/Xcode94.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang test.m -olibtest.i386.dylib -shared -isysroot /Applications/Xcode94.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -framework Foundation -framework CoreLocation -lz  -arch i386
	$ lipo -create libtest.i386.dylib .libs/macos/libtest.dylib -output libtest-fat.dylib

* [tests] Adjust XM tests to XM not having fat dylibs anymore.

* [tests] Adjust product tests to some libraries not being fat anymore.

* [tests] Don't treat an Xcode with the same major version number as old.

Fixes an issue in the MT0091 test, where it would fail on tvOS because the
test wanted to use an older Xcode, and we could end up returning Xcode 11.0
when the current Xcode is 11.1. Since the test depends on using the OS SDK as
it was designed for (technically using an OS SDK earlier than the latest), it
ended up failing because while the iOS SDK was bumped in Xcode 11.1, the tvOS
SDK was not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
+4 more reviewers
@spouliot spouliot spouliot approved these changes
@mandel-macaque mandel-macaque mandel-macaque approved these changes
@chamons chamons chamons approved these changes
@VincentDondain VincentDondain VincentDondain approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ITMS-90806: CFBundleIdentifier collision

7 participants

@rolfbjarne @monojenkins @dalexsoto @spouliot @mandel-macaque @chamons @VincentDondain