[WatchKit] Add WatchKit bindings for Xcode 11.2 - #7202
Conversation
|
Build failure |
| White, | ||
| } | ||
|
|
||
| [Watch (6,1), NoiOS] |
There was a problem hiding this comment.
Yes, the parent interface also has properties/methods that support iOS. WkInterfaceUserTrackingMode only supports WatchOS.
https://developer.apple.com/documentation/watchkit/wkinterfacemap/usertrackingmode
There was a problem hiding this comment.
I don't think it's needed (but there's no harm in it).
WatchKit used to be available on iOS - but it's not anymore (and there are stubs to maintain binary compatibility).
| interface WKInterfaceAuthorizationAppleIdButton { | ||
|
|
||
| [Export ("initWithTarget:action:")] | ||
| [Deprecated (PlatformName.WatchOS, 6,1, message: "Use initWithStyle:target:action:")] |
There was a problem hiding this comment.
I think we have to use the C# method names here instead of the ObjC selectors
There was a problem hiding this comment.
Yup, that's a a placeholder, not sure what the convention is for referring to a c# constructor that's replacing the existing constructor. cc: @spouliot
There was a problem hiding this comment.
I think we used .ctor(...) in some places but
Use "new WKInterfaceAuthorizationAppleIdButton (WKInterfaceVolumeControlOrigin,NSObject,Selector)' instead."
might be better
in doubt use grep on the /src/ directory ;-)
There was a problem hiding this comment.
Yup, that's a a placeholder,
Put a do-not-merge label if there are pending questions on your side. That way someone else won't merge it (e.g. if you're not online). You can remove the label once you have answers.
|
Build success |
|
|
||
| [Watch (6,1)] | ||
| [Export ("setUserTrackingMode:animated:")] | ||
| void SetShowsUserLocation (WKInterfaceMapUserTrackingMode mode, bool animated); |
There was a problem hiding this comment.
wrong name -> should be SetUserTrackingMode
|
|
||
| [Watch (4,0)] | ||
| [Export ("enableWaterLock")] | ||
| [Deprecated (PlatformName.WatchOS, 6,1, message: "Use WKInterfaceDevice.enableWaterLock")] |
There was a problem hiding this comment.
Use C# (not ObjC) syntax + our format, e.g. Use 'X' instead. so
"Use 'WKInterfaceDevice.EnableWaterLock ()' instead.
|
|
||
| [Watch (6,1), NoiOS] | ||
| [Native] | ||
| enum WKInterfaceAuthorizationAppleIDButtonStyle: long { |
There was a problem hiding this comment.
Id, no ID since it's not an acronym
| White, | ||
| } | ||
|
|
||
| [Watch (6,1), NoiOS] |
There was a problem hiding this comment.
I don't think it's needed (but there's no harm in it).
WatchKit used to be available on iOS - but it's not anymore (and there are stubs to maintain binary compatibility).
| interface WKInterfaceAuthorizationAppleIdButton { | ||
|
|
||
| [Export ("initWithTarget:action:")] | ||
| [Deprecated (PlatformName.WatchOS, 6,1, message: "Use initWithStyle:target:action:")] |
There was a problem hiding this comment.
I think we used .ctor(...) in some places but
Use "new WKInterfaceAuthorizationAppleIdButton (WKInterfaceVolumeControlOrigin,NSObject,Selector)' instead."
might be better
in doubt use grep on the /src/ directory ;-)
| interface WKInterfaceAuthorizationAppleIdButton { | ||
|
|
||
| [Export ("initWithTarget:action:")] | ||
| [Deprecated (PlatformName.WatchOS, 6,1, message: "Use initWithStyle:target:action:")] |
There was a problem hiding this comment.
Yup, that's a a placeholder,
Put a do-not-merge label if there are pending questions on your side. That way someone else won't merge it (e.g. if you're not online). You can remove the label once you have answers.
|
Build failure Test results2 tests failed, 89 tests passed.Failed tests
|
* [WatchKit] Add WatchKit bindings for Xcode 11.2
* [WatchKit] Add WatchKit bindings for Xcode 11.2
4 participants
Add WatchKit bindings for Xcode 11.2