Skip to content

[CoreFoundation] Add Clone method for CFArray. #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 1 commit into from
Nov 13, 2019
Merged

[CoreFoundation] Add Clone method for CFArray. #7403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/CoreFoundation/CFArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
using ObjCRuntime;

using CFIndex = System.nint;
using CFArrayRef = System.IntPtr;
using CFAllocatorRef = System.IntPtr;
Comment on lines +38 to +39

@ghost ghost Nov 11, 2019 •
edited by ghost
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we name IntPtrs with using statements and not just use IntPtrdirectly for the parmeter types in Clone()? There's other bindings that use IntPtr directly and mention the objc/c type in an inline comment. What's the standard practice?

@mandel-macaque mandel-macaque Nov 11, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easier to read. I would have changed all, but would have increase the diff. It does not change the output result of the binding.

@dalexsoto dalexsoto Nov 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nice question, but yeah just for readability.

giphy


namespace CoreFoundation {

Expand Down Expand Up @@ -149,6 +151,11 @@ public static nint GetCount (IntPtr array)
{
return CFArrayGetCount (array);
}

[DllImport (Constants.CoreFoundationLibrary)]
extern static CFArrayRef CFArrayCreateCopy (CFAllocatorRef allocator, CFArrayRef theArray);

public CFArray Clone () => new CFArray (CFArrayCreateCopy (IntPtr.Zero, this.Handle), true);
}
}

1 change: 0 additions & 1 deletion tests/xtro-sharpie/common-CoreFoundation.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@
!missing-pinvoke! CFArrayApplyFunction is not bound
!missing-pinvoke! CFArrayBSearchValues is not bound
!missing-pinvoke! CFArrayContainsValue is not bound
!missing-pinvoke! CFArrayCreateCopy is not bound
!missing-pinvoke! CFArrayCreateMutable is not bound
!missing-pinvoke! CFArrayCreateMutableCopy is not bound
!missing-pinvoke! CFArrayExchangeValuesAtIndices is not bound
Expand Down