Skip to content

[Runtime] Enable the -Wsign-conversion on trampolines-varargs files. #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 4 commits into from
Nov 14, 2019
Merged

[Runtime] Enable the -Wsign-conversion on trampolines-varargs files. #7428

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99261eb
[Runtime] Enable the -Wsign-conversion on trampilines-varargs files.
mandel-macaque Nov 13, 2019
12530b9
Revert "[Runtime] Enable the -Wsign-conversion on trampilines-varargs…
mandel-macaque Nov 14, 2019
d50364a
[Runtime] Enable the -Wsign-conversion on trampilines-varargs files.
mandel-macaque Nov 14, 2019
d8d8810
Remove pragma.
mandel-macaque Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions runtime/trampolines-varargs.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
// TODO: temp ignore to minimize diff
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wsign-conversion"

#if !defined (__i386__) && !defined (__x86_64__) && !(defined (__arm64__) && !defined(__ILP32__))
#define __VARARGS_TRAMPOLINES__ 1
#endif
Expand Down Expand Up @@ -132,7 +128,7 @@
case _C_ULNG:
case _C_LNG_LNG:
case _C_ULNG_LNG:
state->longlong_ret = *(uint64_t *) mono_object_unbox (value);
Comment thread
mandel-macaque marked this conversation as resolved.
state->longlong_ret = *(int64_t *) mono_object_unbox (value);
break;

// For pointer types we get the value itself.
Expand Down Expand Up @@ -323,6 +319,4 @@
va_end (state.ap);
}

#endif /* __VARARGS_TRAMPOLINES__ */

#pragma clang diagnostic pop
#endif /* __VARARGS_TRAMPOLINES__ */