[Xcode11.2][CoreFoundation] Make CFBundle.GetAll thread safe. - #7435
Closed
mandel-macaque wants to merge 2 commits into
Closed
[Xcode11.2][CoreFoundation] Make CFBundle.GetAll thread safe.#7435mandel-macaque wants to merge 2 commits into
mandel-macaque wants to merge 2 commits into
Conversation
When working on https://github.com/xamarin/maccore/issues/940 we noticed that clone the array would be a better approach. The CFArrayCreateCopy add some nice things: * The pointer values from theArray are copied into the new array. * The values are also retained by the new array. * The count of the new array is the same as theArray * The new array uses the same callbacks as theArray. [IMPORTANT] Whith this in, we can have a better fix for https://github.com/xamarin/maccore/issues/940
mandel-macaque
added
the
requires-approval-before-merge
Contributor
Author
|
Manual backport because monojenkins could not deal with it. |
mandel-macaque
changed the title
rolfbjarne
reviewed
Nov 13, 2019
rolfbjarne
left a comment
rolfbjarne
left a comment
Member
There was a problem hiding this comment.
I don't think this is important enough to try to get it into xcode11.2.
Contributor
Author
|
@rolfbjarne asking on my side is free hehe |
Contributor
|
Build success |
ghost
approved these changes
Nov 15, 2019
Contributor
Author
|
Closing since back porting and getting a release is not going to happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.