Skip to content

[xcode11.3] [monotouch-test] Make NetworkReachabilityTest.CtorIPAddressPair a bit more permissive. Fixes xamarin/maccore#2047. - #7521

Merged
rolfbjarne merged 1 commit into
dotnet:xcode11.3from
monojenkins:backport-pr-7516-to-xcode11.3
Dec 2, 2019
Merged

[xcode11.3] [monotouch-test] Make NetworkReachabilityTest.CtorIPAddressPair a bit more permissive. Fixes xamarin/maccore#2047.#7521
rolfbjarne merged 1 commit into
dotnet:xcode11.3from
monojenkins:backport-pr-7516-to-xcode11.3

Conversation

@monojenkins

Copy link
Copy Markdown
Contributor

Try to fix https://github.com/xamarin/maccore/issues/2047 by making the test
accept NetworkReachabilityFlags.Reachable for the loopback address on device.

Fixes https://github.com/xamarin/maccore/issues/2047.

Backport of #7516.

/cc @rolfbjarne

… more permissive. Fixes xamarin/maccore#2047.

Try to fix https://github.com/xamarin/maccore/issues/2047 by making the test
accept NetworkReachabilityFlags.Reachable for the loopback address on device.

Fixes https://github.com/xamarin/maccore/issues/2047.
@monojenkins monojenkins added this to the xcode11.3 milestone Dec 2, 2019
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes pr-change-not-shipping The PR only touch files that are not shipped to customers labels Dec 2, 2019
@monojenkins

Copy link
Copy Markdown
Contributor Author

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@chamons chamons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as test only fix.

@rolfbjarne
rolfbjarne merged commit 74a94c3 into dotnet:xcode11.3 Dec 2, 2019
@spouliot

Copy link
Copy Markdown
Contributor

Test still fails :(

https://jenkins.internalx.com/blue/organizations/jenkins/macios/detail/xcode11.3/30/pipeline

[2019-12-17T03:32:13.624Z] 1) CtorIPAddressPair (MonoTouchFixtures.SystemConfiguration.NetworkReachabilityTest.CtorIPAddressPair)
[2019-12-17T03:32:13.624Z]      #3 Reachable
[2019-12-17T03:32:13.624Z]   Expected: 0
[2019-12-17T03:32:13.624Z]   But was:  Reachable, IsLocalAddress, IsDirect
[2019-12-17T03:32:13.624Z] 
[2019-12-17T03:32:13.624Z]   at MonoTouchFixtures.SystemConfiguration.NetworkReachabilityTest.CtorIPAddressPair () [0x000fd] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/monotouch-test/SystemConfiguration/NetworkReachabilityTest.cs:143 
[2019-12-17T03:32:13.624Z]   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
[2019-12-17T03:32:13.624Z]   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/external/mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes pr-change-not-shipping The PR only touch files that are not shipped to customers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants