[Xharness] Fix all xml parsing issues and ensure that the xml can be consumed by VSTS. - #7768
Merged
Conversation
We ping the tcp listener to know that we have a tcp connection, that is written in the xml logs, which means that parsing will not work. Ignore the ping, parse xml, and make sure that the xml that will be consume by vsts is valid.
Contributor
|
Build failure Test results66 tests failed, 21 tests passed.Failed tests
|
rolfbjarne
approved these changes
Jan 29, 2020
Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
Contributor
|
Build failure |
spouliot
approved these changes
Jan 29, 2020
spouliot
referenced
this pull request
Jan 29, 2020
New commits in xamarin/maccore: * xamarin/maccore@80ebc03 [VSTS] Add a status to pending after we ping VSTS for device tests. (#2135) Diff: https://github.com/xamarin/maccore/compare/acfea010d8381fd009ce3a1eaa685d5c8286321d..80ebc03ea89eb4a911bbd73ea45b308b610ab213
Contributor
|
Build failure Test results66 tests failed, 21 tests passed.Failed tests
|
Merged
Contributor
Author
|
build |
mandel-macaque
added
build-package
Contributor
Author
|
build |
mandel-macaque
added
the
run-internal-tests
Contributor
Author
|
build |
chamons
approved these changes
Jan 29, 2020
Contributor
|
Build failure Test results66 tests failed, 21 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException ✅ Build succeeded ✅ API Diff (from stable) |
Contributor
|
Build failure |
Contributor
|
Build failure Test results66 tests failed, 21 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results141 tests failed, 38 tests passed.Failed tests
|
logic closer to the error.
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Packaging' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException |
Contributor
|
Build failure |
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results142 tests failed, 37 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException ✅ Build succeeded ✅ API Diff (from stable) |
mandel-macaque
changed the title
Contributor
|
Build failure ✅ Build succeeded |
Contributor
|
Build failure Test results27 tests failed, 136 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results73 tests failed, 106 tests passed.Failed tests
|
Contributor
|
Build failure Test results27 tests failed, 136 tests passed.Failed tests
|
* Do not clean the xml, seems not to be needed and gives issues with threading. * Set the size of the client buffer in the tcp listener.
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException ✅ Build succeeded ✅ API Diff (from stable) |
Contributor
|
Build failure ✅ Build succeeded |
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Upload to Azure' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException |
Contributor
|
Build failure |
Contributor
|
Build failure Test results1 tests failed, 162 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results1 tests failed, 178 tests passed.Failed tests
|
exception and stop uploading results: ``` Failed to parse result files: System.NotSupportedException: Invalid file format. at Microsoft.TeamFoundation.TestClient.PublishTestResults.NUnitResultParser.ParseTestResultFile(TestRunContext runContext, String filePath) at Microsoft.TeamFoundation.TestClient.PublishTestResults.NUnitResultParser.<>c__DisplayClass1_0.<ParseTestResultFiles>b__0(String file) at System.Linq.Enumerable.SelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source) at Microsoft.TeamFoundation.TestClient.PublishTestResults.NUnitResultParser.ParseTestResultFiles(TestRunContext runContext, IList`1 resultFilePaths) at Microsoft.VisualStudio.Services.Agent.Worker.TestResults.Parser.ParseFiles(IExecutionContext executionContext, TestRunContext testRunContext, List`1 testResultsFiles, ITestResultParser testResultParser) ```
Contributor
|
Build failure Test results1 tests failed, 162 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results1 tests failed, 178 tests passed.Failed tests
|
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Feb 6, 2020
…consumed by VSTS. (dotnet#7768) We ping the tcp listener to know that we have a tcp connection, that is written in the xml logs, which means that parsing will not work. Ignore the ping, parse xml, and make sure that the xml that will be consume by vsts is valid. This PR also fixes https://github.com/xamarin/maccore/issues/827 which does not longer happen.
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Feb 6, 2020
…consumed by VSTS. (dotnet#7768) We ping the tcp listener to know that we have a tcp connection, that is written in the xml logs, which means that parsing will not work. Ignore the ping, parse xml, and make sure that the xml that will be consume by vsts is valid. This PR also fixes https://github.com/xamarin/maccore/issues/827 which does not longer happen.
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Feb 6, 2020
…consumed by VSTS. (dotnet#7768) We ping the tcp listener to know that we have a tcp connection, that is written in the xml logs, which means that parsing will not work. Ignore the ping, parse xml, and make sure that the xml that will be consume by vsts is valid. This PR also fixes https://github.com/xamarin/maccore/issues/827 which does not longer happen.
mandel-macaque
added a commit
to monojenkins/xamarin-macios
that referenced
this pull request
Feb 10, 2020
…consumed by VSTS. (dotnet#7768) We ping the tcp listener to know that we have a tcp connection, that is written in the xml logs, which means that parsing will not work. Ignore the ping, parse xml, and make sure that the xml that will be consume by vsts is valid. This PR also fixes https://github.com/xamarin/maccore/issues/827 which does not longer happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ping the tcp listener to know that we have a tcp connection, that is
written in the xml logs, which means that parsing will not work. Ignore
the ping, parse xml, and make sure that the xml that will be consume by
vsts is valid.
Sample of the ping in CI: http://xamarin-storage/jenkins/xamarin-macios/master/a2a48c4e003b5394a9a354d1dfcd99a064103390/3422594/device-tests/jenkins-results/tests/mscorlib%20Part%201/1621/test-ios-20200128_182116.log