[Harness] Remove the BCLTestProjectInfo class. - #8221
Conversation
Remove two classes that are not really needed and a method. We moved to named tuples to make things simpler. Unfortunally C# does not support: ```csharp using MyNamedTuple = (string Name, double value, bool answer); ``` But we have to live with this. Makes the namespace simpler and removes confusion with the already present project classes that are more widely used.
mandel-macaque
added
run-all-tests
|
PR is a draft because is pointing to the parent branch remove-extra-class-bcl to minimise the diff. Once remove-extra-class-bcl lands will be moved to a normal PR. Doing it so that the review process is easier. |
4d3e8b3 to
ff4ce97
Compare
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException 🔥 Build failed 🔥 |
The class is not really needed. Move to a tuple, make the definition of the group test project nicer since the dictionary initiallization makes it cleaner.
|
Build failure |
ff4ce97 to
ab95d46
Compare
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException 🔥 Build failed 🔥 |
|
Build failure |
|
Build failure Test results1 tests failed, 1047 tests' device not found, 183 tests passed.Failed tests
|
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results5 tests failed, 180 tests passed.Failed tests
|
|
Build failure |
|
Build failure |
| ExtraArgs: null, | ||
| TimeoutMultiplier: 1, | ||
| Projects: new [] { | ||
| ( Name: "mscorlib Part 1", Assemblies: new [] { "monotouch_corlib_xunit-test.part1.dll" }), // special testcase for the corlib which is later used in xHarness for diff config options |
|
Build failure Test results2 tests failed, 1047 tests' device not found, 182 tests passed.Failed tests
|
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: There is already a newer build in progress (#6) |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: There is already a newer build in progress (#6) |
|
Build success |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results5 tests failed, 180 tests passed.Failed tests
|
6 participants
The class is not really needed. Move to a tuple, make the definition of
the group test project nicer since the dictionary initiallization makes
it cleaner.